Open
Conversation
this is a squash commit of all couchbase commits from minodes/newrelic-plugin-agent: - 33c9162f920cd821c6d051302b73ebb2ab27419d fix JSON access - 4e0695788575805e351863384eacf4ab1af1e708 read basicStats from all couchbase buckets - eb58aa6391e747903f9c76fdbb622a64d75dc8c3 basicStats now per bucket sent to newrelic - ede17dcb152838a300f127e5acdd95269482d1ad add couchbase support the original branch used in pull request #404 had a bunch of garbage commits related to other plugins (nagiorelic). i cleaned the unrelated stuff and squashed everything to a single commit
Author
oryband
force-pushed
the
couchbase-plugin
branch
from
d8b0060 to
33a1a57
Compare
There was a problem hiding this comment.
I would move this ifelse block outside of the loop as it doesn't need the loop variable
- add memcached support to couchbase plugin; added logging + pep8 + pep257 - also much easier to add/remove additional metrics in the future - metrics are according to api reference v3.0 or v3.1
oryband
force-pushed
the
couchbase-plugin
branch
from
2edea81 to
e182872
Compare
Author
|
@gmr @notnmeyer mrg plz? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR introduces Couchbase support.
I took on the work of #404 , which was partially-working, and added lots of new features. Primarily:
This PR is split into two commits: The first is the original #404 code with the unrelated parts taken out (nagiorelic). The second is the complete re-write I did.
We at Rounds have been running this on production and it's working great.