Skip to content

fix: Improve Cache Miss Count Warning Relevancy - MEED-9615 - Meeds-io/meeds#3598 #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
boubaker merged 1 commit into from
Aug 26, 2025
Merged

fix: Improve Cache Miss Count Warning Relevancy - MEED-9615 - Meeds-io/meeds#3598 #73

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion ...l.component.cache/src/main/java/org/exoplatform/services/cache/concurrent/CacheState.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -164,9 +164,10 @@ public V remove(Serializable name) {

private void traceExcessiveMissCountRatio() {
int missCount = config.misses.get();
int maxSize = config.getMaxSize();
int hitCount = config.hits.get();
int maxSize = config.getMaxSize();
if (missCount > MIN_MISS_COUNT
&& missCount > (hitCount * 2)
&& missCount % Math.max(MIN_MISS_COUNT, Math.min(maxSize, hitCount)) == 0) { // NOSONAR
log.warn("Cache '{}' seems to have an excessive miss count '{}' (hits count: '{}'), please consider reviewing Max Size '{}' and TTL '{}s' configurations.",
config.getName(),
Expand Down