Upgrade cryppo-js toolchain and dependencies#39
Merged
vijayshiyani merged 9 commits intomasterfrom Feb 16, 2026
Merged
Conversation
- Target es2022 instead of es5, add es2022 lib - Add tsconfig.build.cjs.json and tsconfig.build.esm.json for dual CJS+ESM output - Add .nvmrc pinning Node 22 - Add trailingComma: es5 to Prettier config
- Update bson import to named export, wrap BSON.serialize with Buffer.from - Switch yaml to named imports, pass schema: yaml-1.1 per-call - Fix relative imports in decryption.ts and rsa-signature.ts - Add @ts-expect-error for node-forge createBuffer Uint8Array usage - Add Uint8Array return type to EncryptionKey.bytes - Remove obsolete tslint:disable-next-line comments - Clean up let→const where values are assigned once
- Update jest.config.js with ts-jest transformer config - Remove try/done()/catch/done(err) wrappers from all async tests - Jest 30 natively catches async rejections, making done() unnecessary
- Delete tslint.json (TSLint deprecated since 2019) - Add eslint.config.mjs with typescript-eslint and eslint-config-prettier
- Delete karma.conf.js (Karma deprecated since Apr 2023) - Remove 9 Karma-related packages (done in package.json commit) - Add vite.config.ts for serving demo pages - Update demo HTML: use script type=module, fix paths for Vite - Move scss imports into TS files (Vite handles them natively)
- Version 3.0.0 with Node >=22.0.0 minimum - Update all dependency versions in package.json and package-lock.json - Remove Karma, Parcel, bili, TSLint, sass and legacy type packages - Add ESLint, Vite, sass-embedded, typescript-eslint as dev deps - Add package.json exports field for dual CJS+ESM - Update CI workflows to Node 22, actions v4, npm ci - Remove npm run browser step from all CI workflows - Add CHANGELOG.md - Update README.md to reference Vite instead of Parcel
|
LGTM. Not sure why PR is marked as draft tho. |
There was a problem hiding this comment.
Pull request overview
This PR upgrades cryppo-js toolchain and dependencies from v2.0.2 to v3.0.0, representing a major modernization effort. The upgrade includes Node.js 12.4→22, TypeScript 3.9→5.9, and updates to critical runtime dependencies (node-forge, bson, yaml, buffer). The build system transitions from bili/rollup to dual CJS+ESM TypeScript compilation, and the test/lint infrastructure migrates from deprecated tools (TSLint, Karma) to modern alternatives (ESLint 9, Jest 30).
Changes:
- Raise minimum Node.js version from 12.4 to 22 (breaking change)
- Replace deprecated tooling: TSLint→ESLint 9, Karma→Jest 30 only, Parcel→Vite
- Upgrade runtime dependencies: node-forge 0.10→1.3, bson 4→7, yaml 1→2, buffer 5→6
- Migrate Jest tests from done() callbacks to async/await pattern
- Update test fixtures for node-forge 1.3 strict AES-256 key length enforcement
- Modernize build to dual CJS+ESM output with TypeScript compiler
Reviewed changes
Copilot reviewed 38 out of 42 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Update version to 3.0.0, upgrade all dependencies, change build scripts for dual CJS+ESM output, update exports field |
| tsconfig.json | Upgrade target to es2022, update lib to es2022 |
| tsconfig.build.cjs.json | New config for CommonJS build output to dist/cjs |
| tsconfig.build.esm.json | New config for ES module build output to dist/esm with bundler resolution |
| eslint.config.mjs | New ESLint 9 flat config replacing deprecated TSLint |
| tslint.json | Removed deprecated TSLint configuration |
| jest.config.js | Update ts-jest configuration for Jest 30 with migration notes |
| karma.conf.js | Removed deprecated Karma browser test configuration |
| vite.config.ts | New Vite configuration for demo pages |
| src/util.ts | Update BSON and YAML imports for v7 and v2 APIs, add @ts-expect-error for node-forge type issues, format changes |
| src/encryption-key.ts | Add explicit return type annotation to bytes getter |
| src/encryption/encryption.ts | Change variable declarations from let to const, add @ts-expect-error comments for node-forge |
| src/decryption/decryption.ts | Update imports organization, add @ts-expect-error for node-forge |
| src/signing/rsa-signature.ts | Fix import path from ../../src/util to ../util |
| src/key-pairs/rsa.ts | Remove tslint disable comments |
| src/key-derivation/derived-key.ts | Remove tslint disable comments |
| test/**/*.spec.ts | Migrate all async tests from done() callback pattern to async/await |
| test/encryption/encryption.spec.ts | Update test fixtures with proper 32-byte keys for node-forge 1.3, add explanatory comment |
| test/decryption/decryption.spec.ts | Update test fixtures with proper 32-byte keys and auth tags, add explanatory comment |
| test/serialization.test.ts | Remove tslint disable comments |
| test/compatibility/compatibility.test.ts | Add block scope to switch case, add @ts-expect-error comment |
| demo/*.html | Remove stylesheet links from head, update script tags to type="module", fix navigation paths |
| demo/*.ts | Add stylesheet imports at top of each demo file |
| .github/workflows/*.yaml | Update Node version 10.x/13.x→22.x, upgrade actions to v4, change npm install→npm ci |
| CHANGELOG.md | New changelog documenting v3.0.0 changes |
| .nvmrc | New file specifying Node 22 |
| .prettierrc | Add trailingComma: 'es5' option |
| .npmignore | Add eslint.config.mjs to ignore list |
| .gitignore | Remove Parcel-specific comment |
| README.md | Update demo port from 1234 (Parcel) to 5173 (Vite) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
- Rename demo/styles.scss to styles.css (CSS nesting is native) - Update style imports in demo TS files - Remove jest-junit reporter from jest.config.js - Remove junit.xml from .gitignore and .npmignore
- Remove jest, ts-jest, @types/jest; add vitest - Move test config into vite.config.ts, delete jest.config.js - Replace jest.setTimeout/jasmine blocks with per-test timeout args - Replace JEST_WORKER_ID with VITEST_POOL_ID for Node-only tests - Add test/vitest-globals.d.ts for global type definitions - Update .npmignore, CHANGELOG.md
vijayshiyani
changed the title
Contributor
Author
@linasi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade
cryppo-jstoolchain and dependencies to v3.0.0