Adds scripts for aggregating information on all supported datasets, tasks, and models into JSON files for web ingestion.#211
Adds scripts for aggregating information on all supported datasets, tasks, and models into JSON files for web ingestion.#211mmcdermott wants to merge 7 commits intodevfrom
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new Python script to aggregate multiple JSON result files into a single output, updates the web README with instructions for its usage, adjusts project dependencies and linting options, and adds test fixture setup in conftest.py.
- Adds aggregate_results.py to collate JSON result files.
- Updates README.md for usage instructions.
- Modifies pyproject.toml dependencies and configuration.
- Adds a testing fixture in conftest.py.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| src/MEDS_DEV/web/aggregate_results.py | New aggregation script with JSON error handling |
| src/MEDS_DEV/web/README.md | Added documentation for aggregate_results.py |
| pyproject.toml | Updated dependencies and added doctest options |
| conftest.py | Introduced a fixture for test setup using tempfile |
| {"44": {"result": "data for 44"}, "200": {"result": "data for 200"}} | ||
| """ | ||
| if not input_dir.exists(): | ||
| err_lines = ["Input directory '{input_dir.resolve()!s}' does not exist."] |
There was a problem hiding this comment.
The error message is intended to display the resolved input directory but is missing the 'f' prefix for f-string formatting. Consider changing it to: f"Input directory '{input_dir.resolve()!s}' does not exist."
| err_lines = ["Input directory '{input_dir.resolve()!s}' does not exist."] | |
| err_lines = [f"Input directory '{input_dir.resolve()!s}' does not exist."] |
❌ 1 Tests Failed:
View the top 1 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
…ets in terms of file structures.
These were produced via preliminary files in #211
Closes #186.
Closes #187.
Closes #188.
Need to: