Add the Displaying of Tags to the Item Interface#6
Open
EnigmaSolved wants to merge 3 commits intoMediaBrowser:gh-pagesfrom
Open
Add the Displaying of Tags to the Item Interface#6EnigmaSolved wants to merge 3 commits intoMediaBrowser:gh-pagesfrom
EnigmaSolved wants to merge 3 commits intoMediaBrowser:gh-pagesfrom
Conversation
I'm just guessing regarding "item.Tags" -- wasn't sure where to look to verify that (so this is untested!). For now I've just gone with using the same approach as how Genres are handled of using bullets to separate them (so I mostly just copied and modified the Genres code), but I also think it would be fine to use the gray rounded-corner button look (like the tags appear in the server web interface, and like the media info details appear in ET). I might lean a little more towards the gray button look personally, but this was easier/quicker to implement. :)
Had originally used a Div because was thinking might try to emulate a different style presentation, but am going with P since currently just using same layout as Genres.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please note that this code is untested, but there's not much complexity here so as long as my guess about
item.Tagsis correct everything should run fine. :)I've aimed for displaying the tags directly after the Overview, which is my recommended (and preferred) location, and is also consistent with their location in the Server web-app single-item display. Personally, I'm open to some other locations, but would definitely prefer to have tags displayed somewhere that general area (so, displaying them before the Overview, and after Genres, would be another logical location, though that may run the risk of being confused with Genres).
It might not be a bad idea to eventually add a user setting in the ET client to show or hide Tags (since perhaps some users won't wish to see them displayed), but I'm not familiar enough with the ET architecture yet to do a PR for that.
Let me know if anything else is needed in order to merge this into the core Emby Theater interface.