Skip to content

create package#6

Open
maxcask wants to merge 1 commit intoMedUnes:masterfrom
maxcask:master
Open

create package#6
maxcask wants to merge 1 commit intoMedUnes:masterfrom
maxcask:master

Conversation

@maxcask
Copy link

@maxcask maxcask commented Feb 9, 2026

No description provided.

@codecov
Copy link

codecov bot commented Feb 9, 2026

Codecov Report

❌ Patch coverage is 86.66667% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.05%. Comparing base (d5d87a2) to head (3ff36f6).

Files with missing lines Patch % Lines
...rrors-semantics/20-nil-interface-gotcha/myerror.go 86.66% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##            master       #6      +/-   ##
===========================================
- Coverage   100.00%   97.05%   -2.95%     
===========================================
  Files            1        2       +1     
  Lines           53       68      +15     
===========================================
+ Hits            53       66      +13     
- Misses           0        1       +1     
- Partials         0        1       +1     
Flag Coverage Δ
go-1.25 97.05% <86.66%> (-2.95%) ⬇️
macos-latest 97.05% <86.66%> (-2.95%) ⬇️
ubuntu-latest 97.05% <86.66%> (-2.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@MedUnes
Copy link
Owner

MedUnes commented Feb 9, 2026

Hi @maxcask,

Thanks for the contribution, I'm happy to accept this as the reference implementation for this Kata.

It looks like thefunc (e *MyError) Error() string method is implemented but never called in the tests, we do verify the types and nil-checks (the core of the Kata), but to keep our coverage at 100%, we also need to verify the string output.

Could you please add a simple test case that asserts err.Error() returns the expected string (both for the nil-receiver case and the normal case)?

Once the coverage hits 100%, the CI will turn green and I'll merge immediately. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants