Skip to content

Fix #628: Fixed ASTTemplate couldnt handle empty count() operations#629

Merged
mla2001 merged 2 commits intomainfrom
cr-628
Mar 25, 2026
Merged

Fix #628: Fixed ASTTemplate couldnt handle empty count() operations#629
mla2001 merged 2 commits intomainfrom
cr-628

Conversation

@mla2001
Copy link
Copy Markdown
Contributor

@mla2001 mla2001 commented Mar 25, 2026

Summary

ASTTemplate Visit_Aggregation method now avoids visiting empty node.operands.

Checklist

  • Code quality checks pass (ruff format, ruff check, mypy)
  • Tests pass (pytest)
  • Documentation updated (if applicable)

@mla2001 mla2001 self-assigned this Mar 25, 2026
@mla2001 mla2001 requested review from a team and javihern98 March 25, 2026 11:54
@mla2001 mla2001 linked an issue Mar 25, 2026 that may be closed by this pull request
2 tasks
@mla2001 mla2001 changed the title Fixed ASTTemplate couldnt handle empty count() operations Fix #628: Fixed ASTTemplate couldnt handle empty count() operations Mar 25, 2026
Copy link
Copy Markdown
Contributor

@javihern98 javihern98 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks! 😊

@mla2001 mla2001 merged commit f4aca08 into main Mar 25, 2026
20 checks passed
@javihern98 javihern98 deleted the cr-628 branch March 25, 2026 12:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Fix Visit_Aggregation on ASTTemplate empty count handling

2 participants