Skip to content

Accept casting Scalars inside Sub operator (DO NOT MERGE)#543

Draft
mla2001 wants to merge 12 commits intomainfrom
cr-539
Draft

Accept casting Scalars inside Sub operator (DO NOT MERGE)#543
mla2001 wants to merge 12 commits intomainfrom
cr-539

Conversation

@mla2001
Copy link
Copy Markdown
Contributor

@mla2001 mla2001 commented Feb 26, 2026

Important

DO NOT MERGE until VTL TF review

Summary

Adapt the VTL G4 grammar to accept cast with Scalars (as VarIDs) as the right operand of the Sub operator comparison.

Checklist

  • Code quality checks pass (ruff format, ruff check, mypy)
  • Tests pass (pytest)
  • Documentation updated (if applicable)

Impact / Risk

  • Breaking changes? Sub will now accept casted Scalars (as VarIDs) as the right operand of the sub comparison.

@mla2001 mla2001 self-assigned this Feb 26, 2026
@mla2001 mla2001 linked an issue Feb 26, 2026 that may be closed by this pull request
@mla2001 mla2001 changed the title Cr 539 Cr 539 (DO NOT MERGE) Feb 26, 2026
@mla2001 mla2001 changed the title Cr 539 (DO NOT MERGE) Accept Scalars inside Sub operator (DO NOT MERGE until VTL TF review) Feb 26, 2026
@mla2001 mla2001 changed the title Accept Scalars inside Sub operator (DO NOT MERGE until VTL TF review) Accept Scalars inside Sub operator (DO NOT MERGE) Feb 26, 2026
@mla2001 mla2001 changed the title Accept Scalars inside Sub operator (DO NOT MERGE) Accept casting Scalars inside Sub operator (DO NOT MERGE) Feb 26, 2026
@mla2001 mla2001 marked this pull request as ready for review March 3, 2026 09:37
@mla2001 mla2001 requested review from a team and javihern98 March 3, 2026 09:37
@mla2001 mla2001 marked this pull request as draft March 3, 2026 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Accept Scalars casting inside Sub operator

1 participant