Feature: Add Storybook #205
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This pull request introduces Storybook to the project, adding stories for the TimeSetter and CommitteeStatsTable components along with the necessary configuration and styling. Key changes include:
- Addition of several story files and associated CSS for components such as Page, Header, and Button.
- Setup of Storybook configuration files (.storybook/main.ts, .storybook/preview.ts) and updates to package.json.
- Inclusion of comprehensive documentation through MDX in Configure.mdx.
Reviewed Changes
Copilot reviewed 16 out of 35 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/stories/*.css | Added styling for Storybook pages, header, and buttons. |
| src/stories/*.tsx & *.ts | New story and component files, establishing Storybook stories. |
| src/stories/Configure.mdx | Documentation page with configuration details and guides. |
| package.json, .yarnrc.yml, .storybook/* | New configuration entries to support Storybook integration. |
Comment on lines
+27
to
+28
| fill: 'currentColor', | ||
| 'path fill': 'currentColor' |
There was a problem hiding this comment.
The inline style key 'path fill' is not a valid JavaScript style property and may cause rendering issues. Consider removing it or using a valid CSS property name in camelCase if needed.
Suggested change
| fill: 'currentColor', | |
| 'path fill': 'currentColor' | |
| fill: 'currentColor' |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add Storybook.
Includes stories for
TimeSetterandCommitteeStatsTableMotivation
Addresses issue #181
Screenshots