feat: pass extra_options to database drivers#124
Merged
Conversation
- Add extra_options pass-through to all adapters, allowing users to pass custom driver parameters via connections.json or CLI URLs - Add Snowflake authentication dropdown with support for: - Username & Password (default) - SSO (Browser) - Key Pair (JWT) - OAuth Token - Add conditional fields for private key file and password when JWT is selected
Resolve conflicts in mssql and mysql adapters by combining: - extra_options passthrough from this branch - autocommit enablement (mssql) and charset auto-sync (mysql) from main
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
extra_optionsthrough to database drivers, allowing custom driver parametersFixes #108
Usage
Users can now pass custom driver options via
connections.json:{ "name": "my-snowflake", "db_type": "snowflake", "extra_options": { "authenticator": "snowflake_jwt", "private_key_file": "/path/to/key.p8" } }Or via CLI URL:
sqlit "snowflake://user@account/db?authenticator=snowflake_jwt&private_key_file=/path/to/key.p8"Test plan