Support Python 3.8 #27
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, this package declares that it needs Python >= 3.9, and so pip will not allow you to install it on earlier Python versions.
However, this package actually works fine on Python 3.8; I force-installed it using
pip install 'shfmt-py~=3.11' --ignore-requires-pythonand it installed and worked with no issues.The only reason that this package is currently set to require Python >= 3.9 is because that's the default
min-py-versionfor the setup_cfg_fmt autoformatter, and so the formatter automatically changed the value in this repo's setup.cd (see commit e710e89). This PR updates the pre-commit config to pass--min-py-version '3.8'to setup_cfg_fmt