Added userslist page and userdetail page.#23
Open
ZhangYihanNus wants to merge 5 commits intoMaxPoon:masterfrom
Open
Added userslist page and userdetail page.#23ZhangYihanNus wants to merge 5 commits intoMaxPoon:masterfrom
ZhangYihanNus wants to merge 5 commits intoMaxPoon:masterfrom
Conversation
ZhangYihanNus
changed the title
MaxPoon
reviewed
Oct 27, 2019
Owner
MaxPoon
left a comment
MaxPoon
left a comment
There was a problem hiding this comment.
Can you add some screenshots in the description?
| /** | ||
| * Jump to userlist page | ||
| */ | ||
| JumpToUserslist: function () { |
Owner
There was a problem hiding this comment.
nit: the name should be either users or user list, not users list. and the "L" in "list" should be capitalized.
| // console.log('complete qcloud.request for getting userinfo'); | ||
| // } | ||
| // }); | ||
| qcloud.request({ |
Owner
There was a problem hiding this comment.
why do we comment out the block above and write this new block of code?
| const trainingTableName = "Training"; | ||
|
|
||
| async function get(ctx) { | ||
| var memory = await mysql(trainingTableName).orderBy('UpdatedTime', 'desc').select('*').limit(10); |
Owner
There was a problem hiding this comment.
Can we rename the variable and the file as "trainings"? It's not clear what "memory" means.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Able to access userslist page from homepage "view teammates" button.
Able to further access detail information of each teammate by clicking on them and entering userdetail page.
Url of users' info in GET request needs to be confirmed.