Changed me page data editing#20
Open
ZhangYihanNus wants to merge 8 commits intoMaxPoon:masterfrom
ZhangYihanNus:userinfo
Open
Changed me page data editing#20ZhangYihanNus wants to merge 8 commits intoMaxPoon:masterfrom ZhangYihanNus:userinfo
ZhangYihanNus wants to merge 8 commits intoMaxPoon:masterfrom
ZhangYihanNus:userinfo
Conversation
ZhangYihanNus
changed the title
ZhangYihanNus
changed the title
MaxPoon
reviewed
Jun 1, 2019
| }) | ||
| }, | ||
|
|
||
| formSubmit: function (e) { }, |
| btnDisable: event.detail.value.length === 0 | ||
| }); | ||
| }, | ||
| formSubmit(e) { |
Owner
There was a problem hiding this comment.
let's use the same format - either functionName: function() or functionName().
Owner
|
The screenshot looks good. Let's show a blank field instead of "null" for empty fields. |
Collaborator
|
Can we set the input fields' names and values to different colours (e.g. black and grey) for users to see more clearly? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changed me page data editing method to using a separated page
