[pull] androidx-main from androidx:androidx-main #746
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In cases when source information is not present at runtime (production app builds), the `SourceInformation` flavour of stack traces no longer emits `GroupKeys` based stack traces. Test: ErrorTraceTests Relnote: "Prevent source information stack traces downgrading to group keys in cases when source information is not present at runtime." Change-Id: If371286516f3e0cffecca02926084ea63d2793e5
rememberViewModelStoreNavEntryDecorator is incorrectly using rememberUpdatedState. The current setup is ignoring the result of rememberUpdatedState and will never reconstruct the ViewModelStoreNavEntryDecorator in response to the lambda argument changing. This means that users changing the value of `removeViewModelStoreOnPop` will never see the new lambda argument used as the first one is captured indefinitely. This CL fixes this by invoking the latest value from the rememberUpdatedState instance. Test: testChangeRemoveViewModelStoreOnPop Change-Id: Ie9576520632150dcd34c1bbf45b6b175d09a2f98
Relnote: N/A Test: N/A Change-Id: Id8997f6110b86efc00bfac1cce7f3f4b7cc3fa05
Replaces `entry.content.invoke(entry.key)` with `entry.Content()` in the KDoc examples. This ensures we are no longer using private APIs in the samples. Test: all tests pass Bug: 467164535 Change-Id: I09fe681fb241e9a169594d14d70dfc8ca42e6ba7
A framebuffer with 0 capacity means that the user does not need to pull frames out of the buffer. This is commonly used in preview or viewfinder. Bug: 473901206 Test: FrameBufferImplTest Change-Id: I1ab90035b509a2e9f88129a3ec986e8051087b66
Incremented versionCode to from 92 to 93 and versionName from 1.92 to 1.93 Bug: 476062001 Fixes: 476062001 Test: Manual install and version check on device. APK loads and runs. Change-Id: I27a97bd7f6ebbcaeb9a306cfe6d188a37eab1007
Bug: 474292165 Test: Manual and Unit Change-Id: Ifda88f0a0f0f7700b17af7990adcd5ed277b0003
…" into androidx-main
It's an upstreaming from JB fork. AbstractMainTestClock has nothing target specific and it's preferred to avoid code duplication. Test: N/A Change-Id: Iaefbb7b81bfa9392c604ef2c174522288e33c3f2
Mark SafeIterableMap and FastSafeIterableMap as deprecated. These classes are internal legacy utilities and are not in use anymore. The associated tests have been moved from 'androidx.collection' to 'androidx.arch.core.internal'. By placing the tests in the same package as the deprecated classes, we eliminate the need for explicit imports. This allows the @SuppressWarnings("deprecation") annotation to correctly silence all warnings, which is not possible on explicit import statements. Bug: N/A Test: existing passes Change-Id: I6a5ae5399f43d48da3645b0a79b5519c792bfff1
Test: n/a Change-Id: Icdbaa51f5850941678c24831f8a8b0ccb2129ff2
…eys" into androidx-main
Providers should see the FULLSCREEN compat mode as a LARGE widget, providing the same layout it would for large (although the actual dp size may vary). The renderer will still send FULLSCREEN in the AIDL so that the right size can be cached. Test: unit tests Change-Id: I67cc16027a67d29845404499665fcaafab9547a7
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )