[pull] androidx-main from androidx:androidx-main #744
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to the Kotlin Coroutines documentation, there should be only one `TestCoroutineScheduler` per test environment. This change exposes the scheduler used by the library, whether it was provided by the user or created by default. Access to this specific instance is necessary to ensure synchronization and enables the use of APIs like `runCurrent()`. Test: NA Bug: 254115946 Relnote: "Exposed the TestCoroutineScheduler to enable usage of `runCurrent()` and ensure access to the shared scheduler instance." Change-Id: Iea662686f25332bd583a4512827bb5eab0fc5ad9
This CL introduces the following changes - 1. It decouples the tight dependency on AnnotationsView so that it can unit tested without instrumentation testing requirements. 2. Renames the handleTouch method to findAnnotations which is more idiomatic. 3. Renames the touch handler to AnnotationsLocator. Removes the setListener method and returns the list of annotations instead. 4. The locator returns a list of annotations so that its usage could be broader at the same point. eg. multiple annotation selection 5. Cleaning up AnnotationsView so the locator reinitialises when the pageInfoProvider initialises as well. Bug: 475418945 Test: ./gradlew :pdf:pdf-viewer:test Change-Id: I2ff98696f027e5fbc8977a6dec96346f6c707da2
Test: None Bug: 460508283 Change-Id: I13a633737b1ea1681034e18b3931e8570c08e7c6
…ing." into androidx-main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )