[pull] androidx-main from androidx:androidx-main #738
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Update boolean variable names to follow API guidelines. - Add factory methods for different types of form widgets. - Doc: go/form-filling-processing-layer - Making constructor private and fixing tests will be taken up in follow up CL. Bug: 471094578 Test: FormWidgetInfoTest Change-Id: I55484ffe9453fb0dcacea84be1abbf85d4c7e172
- Update contentExtensions to utilise the factory methods - Update tests to utilise factory methods - Add some sanitation checks in the factory methods Bug: 471094578 Test: FormWidgetInfoTest Change-Id: I1f07fff8e91ac2fa9b1afa1df3b48ec87d2d4d69
BUG: 474687917 Test: N/A Change-Id: I65929ee024b072b6a0f522d2dafa7013c2547896
Also add associated tests within the Wear Compose Material3 remote library. Test: RemoteMaterialThemeTest Bug: 475210339 Change-Id: I008ef65beb331c35c80b6edfb2276905432adb04
Revert submission 3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Reason for revert: Relanding with fix for b/475234286. The aosp cuttlefish emulator contains a bottom nav bar, which obstructs views present at bottom after API 35 enabled edge-to-edge by default. The fix adjusts container to be drawn below status bar and above nav bars. Reverted changes: /q/submissionid:3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Bug: b/472376731 Change-Id: If47c6dbb5eadda3f6b64527bb46213f910ad9f94
Revert submission 3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Reason for revert: Relanding with fix for b/475234286. The aosp cuttlefish emulator contains a bottom nav bar, which obstructs views present at bottom after API 35 enabled edge-to-edge by default. The fix adjusts container to be drawn below status bar and above nav bars. Reverted changes: /q/submissionid:3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Bug: b/472376731 Change-Id: I804833aa405d0fcf0059e5fc64e3af207ca408f5
Revert submission 3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Reason for revert: Relanding with fix for b/475234286. The aosp cuttlefish emulator contains a bottom nav bar, which obstructs views present at bottom after API 35 enabled edge-to-edge by default. The fix adjusts container to be drawn below status bar and above nav bars. Reverted changes: /q/submissionid:3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Bug: b/472376731 Change-Id: I0f8efd1a92113dc37147d76845e84ea91295be35
Revert submission 3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Reason for revert: Relanding with fix for b/475234286. The aosp cuttlefish emulator contains a bottom nav bar, which obstructs views present at bottom after API 35 enabled edge-to-edge by default. The fix adjusts container to be drawn below status bar and above nav bars. Reverted changes: /q/submissionid:3912621-revert-3907980-drag-and-drop-FPUDSWLHLS Bug: b/472376277 Test: ./gradlew :pdf:pdf-ink:connectedAndroidTest Change-Id: Ib433a2396936c59ebc65105c404ea9ab27746994
On AOSP Cuttlefish emulators (API 35+), edge-to-edge display is enabled by default. This causes the bottom navigation bar to overlap with views drawn at the bottom of the screen, leading to failed touch interactions in instrumentation tests. This CL adjusts the test activity's container view to incorporate system bar insets. This ensures that the AnnotationToolbar and other interactive components are drawn within the safe clickable area, avoiding occlusion by the system navigation bar. Bug: b/475234286 Test: ./gradlew :pdf:pdf-ink:connectedAndroidTest Change-Id: I6187509a704376a40b9161edfb03ace8c9b58a75
…urface Local results with Pixel 6: 9,972 ns 3 allocs SurfaceBenchmark.surface_secondDrawFocusAnimation 100,855 ns 87 allocs SurfaceBenchmark.surface_secondFrameFocusAnimation 420,030 ns 107 allocs SurfaceBenchmark.surface_thirdFrameFocusAnimation 73,982 ns 29 allocs SurfaceBenchmark.surface_firstDraw 302,176 ns 29 allocs SurfaceBenchmark.surface_thirdDrawFocusAnimation 57,898 ns 14 allocs SurfaceBenchmark.surface_firstFrame_afterReleaseInteraction 111,219 ns 52 allocs SurfaceBenchmark.surface_firstFrame_afterPressInteraction 746,559 ns 584 allocs SurfaceBenchmark.surface_firstFrame Test: Run benchmark Bug: 472311836 Change-Id: Iafabfa67ccc8992b0eedd6ad38f9a418491ab7c7
…immer.surface" into androidx-main
Update gradient shaders and resolve color stops via creation state. Test: RemoteBrushTest Bug: 465453482 Change-Id: I54d6ae0ab4756d7b41dcd44eed5003474c6babae
…-FPUDSWLHLS-BTJUUJFKPZ" into androidx-main * changes: Fix: account for navigation bar insets in test container Revert "Revert "feat(fragment): Integrate ToolbarCoordinator in ..."
…-FPUDSWLHLS-BTJUUJFKPZ" into androidx-main * changes: Revert "Revert "feat(view): Add ToolbarCoordinator for drag-and-..." Revert "Revert "feat(view): Make AnnotationToolbar draggable and..." Revert "Revert "feat(view): Implement robust drag-and-drop touch..."
…x-main * changes: Make FormWidgetInfo constructor private and update tests. Address feedback for FormWidgetInfo model class
- The PdfContentLayoutTouchListener now create a clone of move event instead of creating a fake down, which misses to capture metadata about the pointer. The stylus works fine with annotation toolbar. - Updates the spanCount of the color palette in the same layout phase instead of next frame to avoid UI glitch. Bug: b/475461521 Test: ./gradlew pdf:pdf-ink:connectedAndroidTest Change-Id: Ifee255d9a430184d75da936868e7084468884d2e
…into androidx-main
… the `XrDeviceCapabilityProviderFactory` to the XR Projected library Bug: 474095480 Test: ProjectedDeviceCapabilityProviderFactoryTest Change-Id: I075701ef04783f85c8276d5f4c70aedb80bf192b
Relnote: N/A Test: ./gradlew ignoreAbiChanges && ./gradlew updateAbi Change-Id: Ib985ce7e9b64ffe0494cd42db50aea7e38be01f6
…tion of the `XrDeviceCapabilityProviderFactory` to the XR Projected library" into androidx-main
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )