Replace use of PathStringUtils with Path#240
Open
edwardcrichton wants to merge 1 commit intodevelopfrom
Open
Conversation
Methods that replace the functionality from 'PathStringUtils': finding the last PathNode with a prefix, getting the last PathNode, getModelIdentifier Path.setModelIdentifier sets the Model Identifier of the first Model PathNode in the Path PathNode holds a list of prefixes that may hold modelIdentifier Path.setModelIdentifier recreates the pathString Updated PathControllerIntegrationSpec: pathApi.getResourceByPath must use a valid path string rather than just a label PathMethodsTest replicates all of the correct tests from PathStringUtils using Path instead PathService uses Path methods in place of PathStringUtils methods, and Path in place of pathString
edwardcrichton
force-pushed
the
feature/pathMethods
branch
from
d583318 to
9d66325
Compare
Collaborator
Author
|
Will need rebasing and conflicts resolved after Feature/folder import export with dataflow #211: DataflowService will be renamed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.