Skip to content

Make pytest-socket optional#218

Open
shocklateboy92 wants to merge 1 commit intoMatthewFlamm:masterfrom
shocklateboy92:fixes/opt-socket
Open

Make pytest-socket optional#218
shocklateboy92 wants to merge 1 commit intoMatthewFlamm:masterfrom
shocklateboy92:fixes/opt-socket

Conversation

@shocklateboy92
Copy link
Copy Markdown

That way, this library can be used for integration/end-to-end tests.

Closes #217

That way, this library can be used for integration/end-to-end tests.
@MatthewFlamm
Copy link
Copy Markdown
Owner

Thank you for this well done contribution! I will keep this open to see if there are any more comments contrary to my comment in #217.

@MatthewFlamm
Copy link
Copy Markdown
Owner

Looked at this again, I'm still of the opinion that we should not change the behavior from ha/core testing. I think that a workaround for users who want to turn it on is to apply the socket_enabled fixture within a fixture that is autoused. If this works, it could be documented in the README here.

@mikart143
Copy link
Copy Markdown

It would gladly improve life quality to drop default pytest-socket settings or make the lib optional. Right now It is impossible to make any integrations tests. Some HA components are made as reverse engineering of other apps. It would help to allow making tests to run those on real life api endpoints which were reverse engineered.

@MatthewFlamm
Copy link
Copy Markdown
Owner

It would gladly improve life quality to drop default pytest-socket settings or make the lib optional. Right now It is impossible to make any integrations tests. Some HA components are made as reverse engineering of other apps. It would help to allow making tests to run those on real life api endpoints which were reverse engineered.

Are you able to try this suggestion #218 (comment)? I haven't tested it myself as I have no use for it, but it seems likely to work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Make the pytest_socket dependency optional

3 participants