Added option for port and formatted file#40
Open
vherrmann wants to merge 1 commit intoMatthewCroughan:masterfrom
Open
Added option for port and formatted file#40vherrmann wants to merge 1 commit intoMatthewCroughan:masterfrom
vherrmann wants to merge 1 commit intoMatthewCroughan:masterfrom
Conversation
Owner
|
The formatting is a bit aggressive, if you get rid of the formatting I'll accept this. |
Author
|
Does the pr fit your expectations now? |
Owner
|
This breaks the tests, not sure why, you can reproduce the tests locally with |
Author
|
I accidentally removed a parenthesis. |
|
Any news on merging this PR? Being able to use different SSH ports (like I do) would be great. 😅 |
|
@MatthewCroughan I'd very much appreciate you merging this PR. |
Author
|
I removed the merge commit with a rebase just now, such that the main repos history isn't cluttered. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you want I can change the commit so that the format isn't affected. Though I personally like the strict formatting of nixfmt.