Python312 django5 update #1
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bumps [isort](https://github.com/pycqa/isort) from 5.5.0 to 5.10.1. - [Release notes](https://github.com/pycqa/isort/releases) - [Changelog](https://github.com/PyCQA/isort/blob/main/CHANGELOG.md) - [Commits](PyCQA/isort@5.5.0...5.10.1) --- updated-dependencies: - dependency-name: isort dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [check-manifest](https://github.com/mgedmin/check-manifest) from 0.42 to 0.48. - [Release notes](https://github.com/mgedmin/check-manifest/releases) - [Changelog](https://github.com/mgedmin/check-manifest/blob/master/CHANGES.rst) - [Commits](mgedmin/check-manifest@0.42...0.48) --- updated-dependencies: - dependency-name: check-manifest dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Support Django4
…k-manifest-0.48 Bump check-manifest from 0.42 to 0.48
…t-5.10.1 Bump isort from 5.5.0 to 5.10.1
Bumps [flake8](https://github.com/pycqa/flake8) from 3.8.3 to 5.0.4. - [Release notes](https://github.com/pycqa/flake8/releases) - [Commits](PyCQA/flake8@3.8.3...5.0.4) --- updated-dependencies: - dependency-name: flake8 dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [pymemcache](https://github.com/pinterest/pymemcache) from 3.3.0 to 3.5.2. - [Release notes](https://github.com/pinterest/pymemcache/releases) - [Changelog](https://github.com/pinterest/pymemcache/blob/master/ChangeLog.rst) - [Commits](pinterest/pymemcache@v3.3.0...v3.5.2) --- updated-dependencies: - dependency-name: pymemcache dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [coverage](https://github.com/nedbat/coveragepy) from 5.2.1 to 6.4.4. - [Release notes](https://github.com/nedbat/coveragepy/releases) - [Changelog](https://github.com/nedbat/coveragepy/blob/master/CHANGES.rst) - [Commits](coveragepy/coveragepy@coverage-5.2.1...6.4.4) --- updated-dependencies: - dependency-name: coverage dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
Bumps [mock](https://github.com/testing-cabal/mock) from 4.0.2 to 4.0.3. - [Release notes](https://github.com/testing-cabal/mock/releases) - [Changelog](https://github.com/testing-cabal/mock/blob/master/CHANGELOG.rst) - [Commits](testing-cabal/mock@4.0.2...4.0.3) Signed-off-by: dependabot[bot] <support@github.com>
…-4.0.3 Bump mock from 4.0.2 to 4.0.3
…mcache-3.5.2 Bump pymemcache from 3.3.0 to 3.5.2
…e8-5.0.4 Bump flake8 from 3.8.3 to 5.0.4
…rage-6.4.4 Bump coverage from 5.2.1 to 6.4.4
Bumps [readme-renderer](https://github.com/pypa/readme_renderer) from 26.0 to 37.0. - [Release notes](https://github.com/pypa/readme_renderer/releases) - [Changelog](https://github.com/pypa/readme_renderer/blob/main/CHANGES.rst) - [Commits](pypa/readme_renderer@26.0...37.0) --- updated-dependencies: - dependency-name: readme-renderer dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <support@github.com>
…me-renderer-37.0 Bump readme-renderer from 26.0 to 37.0
…ttings chore: update tox settings
which began to use to support IPv6 in the pymemcache client since v3.4.0
fix: failed tests
2.0.5Bump version 2.0.5Bump version 2.0.5Bump version 2.0.5Bump version 2.0.5Bump version 2.0.5
Add support Python3.9 and Python3.10
Bump version 2.0.5
…-update # Conflicts: # .travis.yml # django_elastipymemcache/client.py # requirements.txt # tests/test_backend.py # tests/test_client.py # tox.ini
shaib
requested changes
Sep 14, 2025
| 'nodes': servers | ||
| } | ||
| @patch.object(ConfigurationEndpointClient, 'get_cluster_info') | ||
| def test_failed_to_connect_servers(self, get_cluster_info): |
There was a problem hiding this comment.
Did you intend to take this method (and all following test methods) out of the class?
If so, it seems quite weird to leave the self argument
(the change here is combined -- your merge from master put the method in the class, and you then took it out)
| import django | ||
| from django.core.cache import InvalidCacheBackendError | ||
| from nose.tools import eq_, raises | ||
| from nose.tools import eq_ |
There was a problem hiding this comment.
nose is a testing library that the project used in the past, but they took it out in favor of pytest. There should be no imports from it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.