I tried to improve radial waves class in many aspects#41
Open
Arch-User-0 wants to merge 1 commit intoMatheart:mainfrom
Open
I tried to improve radial waves class in many aspects#41Arch-User-0 wants to merge 1 commit intoMatheart:mainfrom
Arch-User-0 wants to merge 1 commit intoMatheart:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I thought the waves should propagate with time, have circular domain. In some cases, if there are several sources in a scene, it is needed to simulate a src start emitting waves while one src is already causing a wave to propagate. I could use functions like move_to() etc, but i wanted to do it with just maths, feel freee to change it if it leads to a better performance
Here are example files i got, i still plan to make it less cluttered in some cases (Eg-#2) but i dont see a way to do it yet with pure maths :
Eg: #1
Eg-#2
You may not recognise some methods from LinearWave class as ive modified it too but i plan not to release it, yet
This is my first PR on github so sorry if i made formatting error or any other mistakes