Introducing the LinearCoeff method as a requirement of the PolynomialLikeVector set of objects#15
Merged
kwesiRutledge merged 2 commits intomainfrom Apr 11, 2025
Conversation
added 2 commits
April 10, 2025 19:38
…and got it working! (Basically)
…nearCoeff function
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #15 +/- ##
=======================================
Coverage 85.70% 85.70%
=======================================
Files 38 38
Lines 5700 5700
=======================================
Hits 4885 4885
Misses 751 751
Partials 64 64 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Several of the vectors that implement the
PolynomialLikeVectorinterface contain aLinearCoeffmethod, but it was never required for those objects. I fixed the implementation ofLinearCoefffor some of those objects and introduced a new "Base method" that does the computation for all of thePolynomialLikeVectorobjects.