Implement GetOptimalObjectiveValue function to evaluate objective at solution point#26
Merged
kwesiRutledge merged 3 commits intomainfrom Oct 15, 2025
Conversation
Co-authored-by: kwesiRutledge <9002730+kwesiRutledge@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Add GetOptimalObjectiveValue using FindValueOfExpression
Implement GetOptimalObjectiveValue function to evaluate objective at solution point
Oct 14, 2025
…27) * Initial plan * Change FindValueOfExpression signature to return symbolic.Expression Co-authored-by: kwesiRutledge <9002730+kwesiRutledge@users.noreply.github.com> * Add helper function to reduce code duplication in tests Co-authored-by: kwesiRutledge <9002730+kwesiRutledge@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: kwesiRutledge <9002730+kwesiRutledge@users.noreply.github.com>
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 86.76% 87.33% +0.57%
==========================================
Files 27 35 +8
Lines 3687 4185 +498
==========================================
+ Hits 3199 3655 +456
- Misses 440 474 +34
- Partials 48 56 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR implements the
GetOptimalObjectiveValuefunction as requested in issue #25. The function evaluates the objective function of an optimization problem at a given solution point by leveraging the existingFindValueOfExpressionfunction.Implementation
The new function has the following signature:
The function works by:
GetProblem()problem.Objective.ExpressionFindValueOfExpressionfunction to substitute all variables in the objective expression with their values from the solutionExample Usage
Error Handling
The function includes proper error handling for:
FindValueOfExpression)Testing
Added four comprehensive test cases covering:
All existing tests continue to pass, confirming no regressions were introduced.
Closes #25
Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.