Merged
Conversation
- Commented out the re-export of low-level APIs to maintain backward compatibility. - Changed the initialization logic to use dynamic import for better control in SSR/custom loading scenarios. - Updated tests to reflect the new initialization method, ensuring the WASM module is loaded correctly. - Removed the unused top-level await plugin from Vite configuration and adjusted the target to 'node20' for consistency with WASM bindings.
- Rename package from to for consistency. - Update README with new usage examples and API references. - Implement a new initialization method for loading the WASM module. - Enhance API functions to return parsed JS objects instead of raw JSON strings. - Add TypeScript definitions for better type safety and developer experience. - Introduce a new for TypeScript compilation settings. - Modify build scripts to include type generation and improve output structure. - Update integration tests to load source maps from the repository for more realistic testing scenarios. - Ensure all API functions are aligned with the new type definitions and return values.
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR modernizes the Node SDK build configuration and removes reliance on top-level await, while updating tests to use real sourcemap files instead of synthetic data.
- Removes
vite-plugin-top-level-awaitdependency and updates build configuration - Switches from synthetic sourcemap generation to real asset-based testing
- Adds comprehensive TypeScript type definitions and improves API documentation
Reviewed Changes
Copilot reviewed 8 out of 10 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| crates/source_map_parser/tests/integration.rs | Replaces synthetic sourcemap tests with real asset-based testing |
| crates/node_sdk/vite.config.mjs | Removes top-level-await plugin and updates build target |
| crates/node_sdk/tsconfig.json | Adds TypeScript configuration for declaration generation |
| crates/node_sdk/tests/test_basic.test.mjs | Updates test imports to use new init pattern |
| crates/node_sdk/src/types.ts | Adds comprehensive TypeScript type definitions |
| crates/node_sdk/src/index.ts | Major rewrite with proper TypeScript types and documentation |
| crates/node_sdk/package.json | Updates build scripts and output filename |
| crates/node_sdk/README.md | Updates documentation with new API examples |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.