Skip to content

check for a passed DOM node #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
felixzapata wants to merge 2 commits into
base: master
Choose a base branch
from
Open

check for a passed DOM node #8

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f76cf0d
fix(Bar.js): check for a passed DOM node
felixzapata Sep 26, 2018
b191b91
fix(Speaker.js): check for a passed DOM node
felixzapata Sep 26, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion erizo_controller/erizoClient/src/views/Bar.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,7 +69,12 @@ const Bar = (spec) => {
waiting = setTimeout(show, 1000);
};

document.getElementById(that.elementID).appendChild(that.div);
// Check for a passed DOM node.
if (typeof that.elementID === 'object' && typeof that.elementID.appendChild === 'function') {
that.elementID.appendChild(that.div);
} else {
document.getElementById(that.elementID).appendChild(that.div);
}
that.div.appendChild(that.bar);
that.bar.appendChild(that.link);
that.link.appendChild(that.logo);
Expand Down
8 changes: 7 additions & 1 deletion erizo_controller/erizoClient/src/views/Speaker.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,13 @@ const Speaker = (spec) => {
show('none');
}

document.getElementById(that.elementID).appendChild(that.div);
// Check for a passed DOM node.
if (typeof that.elementID === 'object' && typeof that.elementID.appendChild === 'function') {
that.elementID.appendChild(that.div);
} else {
document.getElementById(that.elementID).appendChild(that.div);
}

return that;
};

Expand Down