Resolve #11 #12
Draft
Resolve #11 #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taiseiKMC
force-pushed
the
hsaito/issue-11
branch
2 times, most recently
from
c9c62c0 to
138c8a9
Compare
…arison operators accordingly
calling is.peek twice at eof sometimes cause is.fail
…alComparison and add decimalCalculation cases
taiseiKMC
force-pushed
the
hsaito/issue-11
branch
from
138c8a9 to
86cb8c2
Compare
MasWag
requested changes
Dec 21, 2025
Owner
MasWag
left a comment
MasWag
left a comment
There was a problem hiding this comment.
Please remove unnecessary comments.
| std::array<std::vector<std::pair<op_t, atom_t>>, 2> tail; | ||
| //! @brief comparison in the constraint | ||
| comparison_t comparison = comparison_t::EQ; | ||
| // (head[0] tail[0][0].first tail[0][0].second ...) comparison (head[1] tail[1][0].first tail[1][0].second ...) |
Owner
There was a problem hiding this comment.
This is likely an unnecessary comment.
| void toExpr(const std::size_t parameterSize, const atom_t &atom, | ||
| Parma_Polyhedra_Library::Linear_Expression &expr) const { | ||
| static auto toExpr(const std::size_t parameterSize, const atom_t &atom) { | ||
| // Coefficient は denominator |
Owner
There was a problem hiding this comment.
This is also likely an unnecessary comment.
| return expr; | ||
| } | ||
|
|
||
| // constraint で ParametricTimingConstraint = Parma_Polyhedra_Library::NNC_Polyhedron の add_constraint する |
Owner
There was a problem hiding this comment.
This is also likely an unnecessary comment.
| void extract(const std::size_t parameterSize, Parma_Polyhedra_Library::Constraint &constraint) const { | ||
| std::array<Parma_Polyhedra_Library::Linear_Expression, 2> expr; | ||
| std::array<std::pair<Parma_Polyhedra_Library::Linear_Expression, Parma_Polyhedra_Library::Coefficient>, 2> expr; | ||
| // head[i], tail[i] から expr[i] を生成 |
Owner
There was a problem hiding this comment.
This is also likely an unnecessary comment.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #11,
Timestampto monitorsdoubleasTimestampwhen using data_parametric_monitor and boolean_monitor,PPLRationalwhen using parametric_monitorPPLRationalextractfunction carefullytimingconstraint_timestamp_tto avoid adding an additional template type parameterTimestamptoSymonParser, that has some constexpr branching depending on the type structure ofTimingConstraing<Timestamp>