Microsoft Store/MSIX bundling + CI workflow, and persist settings in packaged path #33
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implemented logic to detect if OLEDShift is running as a packaged app. If packaged, settings are saved to the app's LocalState folder, otherwise, it defaults to the executable directory for portable use
Better than creating it myself and this approach might scale better if and when support for multiple platforms gets added
There was a problem hiding this comment.
Pull request overview
This PR adds Microsoft Store packaging support for OLEDShift by introducing MSIX bundling with GitHub Actions automation and improved settings persistence for packaged applications.
- Implements settings path resolution that works for both packaged (Microsoft Store) and unpackaged (portable) deployments
- Adds automated MSIX bundle creation via GitHub Actions workflow
- Includes MSIX manifest files and assets for x64 and ARM64 architectures
Reviewed changes
Copilot reviewed 8 out of 18 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
src/settings_path.rs |
New module for determining settings file location based on app packaging state |
src/settings.rs |
Updated to use dynamic settings path instead of hardcoded path |
src/main.rs |
Added settings_path module declaration |
Cargo.toml |
Added windows crate dependency for Windows Runtime API access |
Cargo.lock |
Added windows crate and its dependencies to lock file |
.github/workflows/rust.yml |
Updated to support workflow_call and upgraded action versions |
.github/workflows/msix_bundle.yml |
New workflow for automated MSIX bundle creation on tags |
uwp/*/AppxManifest.xml |
MSIX package manifests for x64 and ARM64 architectures |
uwp/*/Assets/*.png |
Application logos for Microsoft Store listing |
uwp/store-assets/*.jpg |
Store listing screenshot assets |
.gitignore |
Added output directory and exe files to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds Microsoft Store packaging support for OLEDShift by introducing MSIX bundling, a GitHub Actions workflow that builds the bundle automatically, and improved settings persistence when running as a packaged app