Add selectable monitor support, #25 #28
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Addresses user feedback for improved multi-monitor compatibility, especially for setups with mixed display types
There was a problem hiding this comment.
Pull request overview
This PR adds selectable monitor support to address multi-monitor compatibility issues. Users can now enable/disable the mouse mover feature per monitor through a new "Screens" submenu in the system tray.
- Introduces monitor detection and management via Windows API
- Adds UI controls for per-monitor enable/disable toggles
- Persists monitor preferences in settings
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 10 comments.
Show a summary per file
| File | Description |
|---|---|
| src/view.rs | Adds "Screens" submenu with dynamic menu items for each monitor, handles monitor selection events |
| src/settings.rs | Adds enabled_monitors HashMap to settings struct with getter/setter methods for monitor state |
| src/mover.rs | Implements monitor filtering logic to skip windows on disabled monitors |
| src/monitor_info.rs | New module providing Windows API helpers to enumerate monitors and retrieve display device information |
| src/main.rs | Registers the new monitor_info module |
| src/controller.rs | Adds global ENABLED_MONITORS state and methods to merge connected/saved monitor data |
| Cargo.toml | Adds required winapi features for monitor enumeration |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses user feedback for improved multi-monitor compatibility, especially for setups with mixed display types