Fix navbar overflow detection on mobile#137
Merged
MarketDataApp merged 3 commits intomainfrom Mar 6, 2026
Merged
Conversation
… detection The overflow JS detects items to hide by checking for flex-item compression, which only occurs when flex-wrap: nowrap is set. Previously nowrap was only applied at ≥997px, so the login button stayed visible on mobile even when there was no room for it.
Sheets now uses automatic Google Authentication, but the troubleshooting and mobile-devices pages still referenced the old token-based flow. This was causing support agents to give incorrect guidance about adding tokens in the sidebar.
Adds scrollWidth fallback detection for navbar overflow (MarketDataApp/ui#7).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
flex-wrap: nowrapon.navbar__innerat all widths (not just ≥997px) so the overflow JS can detect flex-item compression on mobile@marketdataapp/uito v2.10.0 which adds ascrollWidth > clientWidthfallback detection method (navbar-overflow: add scrollWidth fallback detection ui#7)Test plan