Skip to content

Conversation

@yhr0x43
Copy link

@yhr0x43 yhr0x43 commented Apr 9, 2025

I have some friends who can't read English but I would like to share this pack with. This change is to make localization to any language easier. Also it provides a possibility for partial translation with the original English as a fallback, so any translation work can be kind of "future-proof" even when the quests keep updating.

@yhr0x43
Copy link
Author

yhr0x43 commented Apr 9, 2025

I just noticed the quest-rework branch. Maybe this should at least wait until that is done? Regardless the scripts for automatically extract and replace translation key should still be useful.

@pawjwp
Copy link
Collaborator

pawjwp commented Apr 9, 2025

This is an excellent change and thank you so much for making the scripts to automate most of the process. I would absolutely like to have translation keys as a long-term goal of the project, though it has been on the back burner since I want the quests to be mostly complete before they are implemented as it will make things a bit more difficult to maintain.

The quest rework has been my personal project for the past month, but I only moved it into that branch in the past few days, so sorry if you missed it. (It was previously on my own fork of the project.)

I would love to integrate these changes now, but do you have any ideas about how we could avoid merge conflicts when merging in the other branch in the future? Should I just wait until the quest rework is done and then run the scripts on that branch? Merging HQM quests are difficult because the files completely rearrange themselves whenever they are saved in-game. I guess the best of both worlds is to:

  1. Accept this pull request now
  2. Run your scripts on the quest-rework branch when that is reaching a finished state
  3. Get the quest-rework branch to an almost-finished state
  4. Run the scripts on the quest-rework branch
  5. Completely overwrite all main branch quest files with the quest-rework branch ones (a normal merge would likely fail)

I haven't looked over your scripts in detail yet, but would that be the best approach? Again, thank you so much for these, this is a great idea and saves me a lot of work in the future.

@yhr0x43
Copy link
Author

yhr0x43 commented Apr 9, 2025

I actually don't know what would be the best for avoiding merge conflicts. I personally would just avoid the headache of thinking a rigorous system and guideline to avoid conflict. The number of commits and branches involved here seems low enough to just deal with merging them manually.
I see how this can be problematic when editing and saving quests in game. But I am willing to work on just merging the files manually and write jq scripts as needed. I think your plan is great and thank you for the accommodation (so I can give my friends the modpack already with translation key support). But yes, for step 5, I can help with rebasing or merging. I love this modpack, actually played the original one with said friend nearly 10 years ago. This project is amazing and I want to support it!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants