Hidden row handling #186
Merged
Hidden row handling #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
Author
|
@0xced I've implemented the hidden row feature for all supported types. I need to add more unit tests though, as I'm concerned about some corner cases, especially for .xls files. Maybe you can test this branch with your use case and see if it handles your needs at least. I'm going to try to finish this feature up, and maybe handle hidden columns separately (if at all). |
Contributor
|
Sorry for the long delay. I just tried your |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the ability to inspect if a row is hidden, and adds an option to have the reader skip hidden rows via ExcelDataReaderOptions.ReadHiddenRows, which defaults to true for backwards compat.