Begin implementing intra-basic block liveness analysis#1
Open
MarkMcCaskey wants to merge 1 commit intomasterfrom
Open
Begin implementing intra-basic block liveness analysis#1MarkMcCaskey wants to merge 1 commit intomasterfrom
MarkMcCaskey wants to merge 1 commit intomasterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This code is exposing a bug in the live-in checking, which suggests that the core algorithm may be implemented incorrectly. This'll take some solid debugging and investigation to figure out.
This PR adds the logic for checking when registers stop being used within a single basic block so that registers can be used more efficiently (i.e. A = A + 1 doesn't need a new register each time).
When commenting out the
!live_inregister freeing on basic block entry, the code miscompiles and the loop only executes once instead of 4 times. This is surprising as the live-in register freeing is more of an optimization than a hard requirement (when we lack register pressure at least)... This is suggestive of another bug in the code added by this PR