Skip to content

Marcosdy/vault refactor km #531

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
MarcosDY wants to merge 52 commits into
base: main
Choose a base branch
from
Open

Marcosdy/vault refactor km #531

MarcosDY wants to merge 52 commits into from

Conversation

@MarcosDY
Copy link
Owner

@MarcosDY MarcosDY commented Oct 18, 2025

Pull Request check list

  • Commit conforms to CONTRIBUTING.md?
  • Proper tests/regressions included?
  • Documentation updated?

Affected functionality

Description of change

Which issue this PR fixes

@InverseIntegral @MarcosDY
Create skeleton of HC Vault based server keymanager plugin (spiffe#5058)
042b8e1 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Start implementing signing function for HC vault (spiffe#5058)
d8f7d98 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make SignData work with HC Vault keymanager plugin (spiffe#5058)
27592b0 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Rename transit key type constants (spiffe#5058)
5caafd1 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make vault client more robust by handling invariant violations (spiff…
bd62d68 
…e#5058)

Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Move logic from plugin to vault client (spiffe#5058)
7ac1a7b 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Refactor logic to generate vault client (spiffe#5058)
ac9d657 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Use latest key version to sign data (spiffe#5058)
ff66d99 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Move data encoding to vault client (spiffe#5058)
8380233 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add simple vault client auth test (spiffe#5058)
e010de9 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove unused test code (spiffe#5058)
cc167ab 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support configuring vault namespace (spiffe#5058)
409e527 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support AppRole authentication (spiffe#5058)
f6ce1ac 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make transit engine path configurable (spiffe#5058)
fcbb163 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add comments to exported functions (spiffe#5058)
186eb04 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support certificate authentication (spiffe#5058)
355cf39 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add missing app role auth test case (spiffe#5058)
7cf6e61 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support K8s auth (spiffe#5058)
f417001 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Support verifying server certificate via CA (spiffe#5058)
7a8aab3 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault client create key function (spiffe#5058)
527e342 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault client get key function (spiffe#5058)
5a31f7d 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault client sign data function (spiffe#5058)
c2c9d37 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault key manager configure function (spiffe#5058)
f615cf8 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test vault key manager generate key function (spiffe#5058)
c7fc59c 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Load keys from Vault on configure (spiffe#5058)
64b0601 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test get key entry function (spiffe#5058)
3aa2cea 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Test get keys function (spiffe#5058)
1c15903 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add simple plugin documentation (spiffe#5058)
ebfc71f 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove unused hooks (spiffe#5058)
da50cd9 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Fix hcl examples in documentation (spiffe#5058)
218c6da 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
InverseIntegral and others added 17 commits October 3, 2025 10:03
@InverseIntegral @MarcosDY
Add KeyManager vault integration test (spiffe#5058)
9f418a2 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add warning when skipping TLS verification (spiffe#5058)
73e3481 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Prevent shadowing of variable (spiffe#5058)
e6ccdca 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Improve comment (spiffe#5058)
babefdb 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Add type assertion check (spiffe#5058)
987d795 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove TODO (spiffe#5058)
60aa851 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Remove TODO (spiffe#5058)
8d3ed46 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Introduce unique server id for HA setup (spiffe#5058)
2fcbe7d 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Make key names unique by adding a UUID (spiffe#5058)
cd8052a 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@InverseIntegral @MarcosDY
Cleanup keys with same SPIRE key id (spiffe#5058)
a96511c 
Signed-off-by: Matteo Kamm <github@matteokamm.ch>
@MarcosDY
resolve lint issues and implement Validate in plugin
269875f 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
Resolve file issue
013696c 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
Require validate provided key identifier
79cebc5 
Signed-off-by: Marcos Yacob <marcosyacob@gmail.com>
@MarcosDY
starting refactor
6034c18
@MarcosDY
some impr
30f422b
@MarcosDY
more
356a944
@MarcosDY
more lint
34ab39a
@MarcosDY MarcosDY force-pushed the marcosdy/vault-refactor-km branch from d88fec5 to 34ab39a Compare October 18, 2025 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@MarcosDY @InverseIntegral