Merged
Conversation
navbar component with styling without routing
footer component with styling
added a component that consists of header, search form with widget
image of the day with styling
news of the day widget with styling
recent searches multi-component with child components and styling
simple about page according to specs
simple contact page according to specs
all components integrated but without routing
padding was added to better fit the design
border radius is now matching navbars border radius
routing is now done using vue-router
rename page views to look the same
error handling defaults to one page
while loading with default time of 3s the loading page is being displayed
router functionality is now in router/index.ts
new function was introduced to divide the flow of the request
result page now handles the search results display
remove unused node modules
Contributor
There was a problem hiding this comment.
Copilot reviewed 26 out of 30 changed files in this pull request and generated 3 comments.
Files not reviewed (4)
- frontend/package-lock.json: Language not supported
- frontend/package.json: Language not supported
- frontend/src/assets/base.css: Language not supported
- frontend/src/assets/main.css: Language not supported
|
|
||
| const recentSearches = [ | ||
| { query: 'Is this love?', url: 'https://example.com' }, | ||
| { query: 'Is Trum the president of US?', url: 'https://example.com' }, |
There was a problem hiding this comment.
Consider correcting the query text by replacing 'Trum' with 'Trump'.
Suggested change
| { query: 'Is Trum the president of US?', url: 'https://example.com' }, | |
| { query: 'Is Trump the president of US?', url: 'https://example.com' }, |
| const recentSearches = [ | ||
| { query: 'Is this love?', url: 'https://example.com' }, | ||
| { query: 'Is Trum the president of US?', url: 'https://example.com' }, | ||
| { query: 'Cracow is the capitol of Moldova', url: 'https://example.com' }, |
There was a problem hiding this comment.
[nitpick] Review the query text, as 'capitol' may be a misspelling of 'capital' if referring to a city.
Suggested change
| { query: 'Cracow is the capitol of Moldova', url: 'https://example.com' }, | |
| { query: 'Cracow is the capital of Moldova', url: 'https://example.com' }, |
| form$.submitting = false | ||
| } | ||
| const onSubmit = async () => { | ||
| console.log('This is searchFormComponent: \n' + { ...s }) |
There was a problem hiding this comment.
Consider replacing the object concatenation with JSON.stringify(s) to properly log the search parameters.
Suggested change
| console.log('This is searchFormComponent: \n' + { ...s }) | |
| console.log('This is searchFormComponent: \n' + JSON.stringify(s)) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backend and frontend work together
Closes: #21
Closes: #20
Closes: #19
Closes: #18
Closes: #17
Closes: #16