Skip to content

Fixes and improvements #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
JanuszBedkowski merged 3 commits into from
Jan 16, 2026
Merged

Fixes and improvements #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d35646c
Fixes and improvements
yuckinus Jan 16, 2026
b639a3b
Merge branch 'main' into main
yuckinus Jan 16, 2026
a38721d
fix
yuckinus Jan 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions apps/lidar_odometry_step_1/lidar_odometry_gui.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -184,6 +184,8 @@ std::chrono::time_point<std::chrono::system_clock> loStartTime;
std::atomic<double> loElapsedSeconds{ 0.0 };
std::atomic<double> loEstimatedTimeRemaining{ 0.0 };

fs::path outwd;

#if _WIN32
#define DEFAULT_PATH "C:\\"
#else
Expand Down Expand Up @@ -670,7 +672,7 @@ void step2(const std::atomic<bool>& loPause)

void save_results(bool info, double elapsed_seconds)
{
fs::path outwd = get_next_result_path(working_directory);
outwd = get_next_result_path(working_directory);
save_result(worker_data, params, outwd, elapsed_seconds);
if (info)
{
Expand Down Expand Up @@ -883,9 +885,9 @@ void settings_gui()

ImGui::NewLine();

ImGui::InputDouble("Decimation", &params.decimation, 0.0, 0.0, "%.3f");
ImGui::InputDouble("Downsampling", &params.decimation, 0.0, 0.0, "%.3f");
if (ImGui::IsItemHovered())
ImGui::SetTooltip("Larger value of decimation better performance, but worse accuracy");
ImGui::SetTooltip("Larger value of downsampling better performance, but worse accuracy");

ImGui::InputDouble("Max distance of processed points [m]", &params.max_distance_lidar, 0.0, 0.0, "%.2f");
if (ImGui::IsItemHovered())
Expand Down Expand Up @@ -1100,7 +1102,7 @@ void settings_gui()
ImGui::SameLine();
ImGui::Checkbox("Show buckets", &show_reference_buckets);
ImGui::SetNextItemWidth(ImGuiNumberWidth);
ImGui::InputInt("Decimation###ref", &dec_reference_points);
ImGui::InputInt("Downsamplingn###ref", &dec_reference_points);

if (ImGui::Button("Filter reference buckets"))
{
Expand Down Expand Up @@ -1564,9 +1566,9 @@ void openData()
loRunning = false;

std::ostringstream oss;
oss << "Data saved to folder:\n'" << working_directory << "\\lio_result_*'\n"
<< "Calculated trajectory length: " << std::fixed << std::setprecision(1)
<< params.total_length_of_calculated_trajectory << "[m]\n"
oss << "Data saved to folder:\n'" << outwd.string() << "'\n"
<< "Calculated trajectory length: "
<< std::fixed << std::setprecision(1) << params.total_length_of_calculated_trajectory << "[m]\n"
<< "Elapsed time: " << formatTime(elapsed_seconds.count()).c_str();

[[maybe_unused]] pfd::message message("Information", oss.str(), pfd::choice::ok, pfd::icon::info);
Expand Down
10 changes: 5 additions & 5 deletions apps/lidar_odometry_step_1/resource.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ IDI_ICON1 ICON "icon.ico"
//

VS_VERSION_INFO VERSIONINFO
FILEVERSION 0, 0, 9, 5
PRODUCTVERSION 0, 0, 9, 5
FILEVERSION 0, 0, 9, 6
PRODUCTVERSION 0, 0, 9, 6
FILEFLAGSMASK 0x3fL
FILEOS 0x40004
FILETYPE 0x1
Expand All @@ -32,11 +32,11 @@ BLOCK "040904B0"
BEGIN
VALUE "CompanyName", "Mandeye\0"
VALUE "FileDescription", "HDMapping Step 1\0"
VALUE "FileVersion", "0.9.5\0"
VALUE "FileVersion", "0.9.6\0"
VALUE "InternalName", "Odometry\0"
VALUE "LegalCopyright", "(c) 2025 github.com/MapsHD/HDMapping\0"
VALUE "LegalCopyright", "(c) 2026 github.com/MapsHD/HDMapping\0"
VALUE "OriginalFilename", "lidar_odometry_step_1.exe\0"
VALUE "ProductVersion", "0.9.5\0"
VALUE "ProductVersion", "0.9.6\0"
VALUE "ProgramID", "github.com/MapsHD/HDMapping\0"
VALUE "ProductName", "HDMapping\0"
END
Expand Down
10 changes: 5 additions & 5 deletions apps/mandeye_mission_recorder_calibration/resource.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ IDI_ICON1 ICON "icon.ico"
//

VS_VERSION_INFO VERSIONINFO
FILEVERSION 0,0,9,5
PRODUCTVERSION 0,0,9,5
FILEVERSION 0,0,9,6
PRODUCTVERSION 0,0,9,6
FILEFLAGSMASK 0x3fL
FILEOS 0x40004
FILETYPE 0x1
Expand All @@ -32,11 +32,11 @@ BEGIN
BEGIN
VALUE "CompanyName", "Mandeye\0"
VALUE "FileDescription", "HDMapping MR Calibration\0"
VALUE "FileVersion", "0.9.5\0"
VALUE "FileVersion", "0.9.6\0"
VALUE "InternalName", "Mission Recorder Calibration\0"
VALUE "LegalCopyright", "(c) 2025 github.com/MapsHD/HDMapping\0"
VALUE "LegalCopyright", "(c) 2026 github.com/MapsHD/HDMapping\0"
VALUE "OriginalFilename", "mandeye_mission_recorder_calibration.exe\0"
VALUE "ProductVersion", "0.9.5\0"
VALUE "ProductVersion", "0.9.6\0"
VALUE "ProgramID", "github.com/MapsHD/HDMapping\0"
VALUE "ProductName", "HDMapping\0"
END
Expand Down
10 changes: 5 additions & 5 deletions apps/mandeye_raw_data_viewer/resource.rc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,8 @@ IDI_ICON1 ICON "icon.ico"
//

VS_VERSION_INFO VERSIONINFO
FILEVERSION 0,0,9,5
PRODUCTVERSION 0,0,9,5
FILEVERSION 0,0,9,6
PRODUCTVERSION 0,0,9,6
FILEFLAGSMASK 0x3fL
FILEOS 0x40004
FILETYPE 0x1
Expand All @@ -32,11 +32,11 @@ BEGIN
BEGIN
VALUE "CompanyName", "Mandeye\0"
VALUE "FileDescription", "HDMapping Raw Data Viewer\0"
VALUE "FileVersion", "0.9.5\0"
VALUE "FileVersion", "0.9.6\0"
VALUE "InternalName", "Raw data viewer\0"
VALUE "LegalCopyright", "(c) 2025 github.com/MapsHD/HDMapping\0"
VALUE "LegalCopyright", "(c) 2026 github.com/MapsHD/HDMapping\0"
VALUE "OriginalFilename", "mandeye_raw_data_viewer.exe\0"
VALUE "ProductVersion", "0.9.5\0"
VALUE "ProductVersion", "0.9.6\0"
VALUE "ProgramID", "github.com/MapsHD/HDMapping\0"
VALUE "ProductName", "HDMapping\0"
END
Expand Down
Loading