Conversation
Signed-off-by: missac213 <106991808+missac213@users.noreply.github.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
…a-rs into feat/move-glv
…a-rs into feat/move-glv
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
bhgomes
suggested changes
Sep 20, 2022
Contributor
There was a problem hiding this comment.
Another comment:
The file structure for the benchmarking library is a bit complicated. I would recommend the following flatter structure:
- manta-benchmark
- src
- lib.rs (contains Benchmark trait)
- glv.rs (contains GLV impl of Benchmark trait)
- ecc.rs (contains ECC benchmark definitions)
Also, see my notes in the manta-crypto/src/glv/mod.rs file on moving the AffineCurveExt trait.
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
BoyuanFeng
reviewed
Oct 17, 2022
BoyuanFeng
reviewed
Oct 17, 2022
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
bhgomes
previously approved these changes
Oct 27, 2022
SupremoUGH
previously approved these changes
Oct 27, 2022
all changes implemented, merging
Signed-off-by: Francisco Hernandez Iglesias <f.hernandeziglesias@outlook.com>
Signed-off-by: Brandon H. Gomes <bhgomes@pm.me>
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE: Move to OpenZL.
Changes:
manta-crypto/src/glv: GLV scalar product implementation, including sage scripts which compute the GLV parameters for BLS and BN and correctness tests.manta-benchmark: AddedBenchmarktrait and implemented it for GLV, which is now benchmarked. It shows the expected performance improvement. TODO: implementBenchmarktrait for the other benchmarked functions, I plan to do this as part of DO NOT MERGE: Feat/test benchmark suite crypto primitives #208. Also planning to expandbenchmark/eccto the BN curve in that PR.Performance Benefits: 31% less constraints in R1CS. See https://www.notion.so/mantanetwork/Scalar-multiplication-of-elliptic-curves-194a4e70a4f943a7acbab549d4331a4d for the full details.
Closes #209
Before we can merge this PR, please make sure that all the following items have been checked off:
CHANGELOG.mdand added the appropriatechangeloglabel to the PR.Files changedin the GitHub PR explorer.CONTRIBUTING.md.