Skip to content

fix: notification failing in kubernetes #54

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
cidopenup0 wants to merge 1 commit into
base: stage
Choose a base branch
from
Open

fix: notification failing in kubernetes #54

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion manifests/kubernetes/login-service.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ data:
DB_PORT: "3306"
DB_NAME: empdir
JWT_EXPIRATION_MS: "86400000"
NOTIFICATION_SERVICE_URL: http://api.microforge.manojm.site
NOTIFICATION_SERVICE_URL: http://notification-service:8083
Copy link
Owner

@Manoj-14 Manoj-14 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I need url to be http://api.microforge.manojm.site

Copy link
Author

@cidopenup0 cidopenup0 Jan 13, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

alright iam working it

Copy link
Author

@cidopenup0 cidopenup0 Jan 13, 2026 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Manoj-14 i have tried to add ip of ingress-nginx-controller cluster IP but this is considered as bad practice so i consider the old http://notification-service:8083 way as better option and using service names is standard practice for service to service communication

    spec:
+      hostAliases:
+      - ip: "10.102.83.6"  # ingress-nginx-controller ClusterIP
+        hostnames:
+        - "api.microforge.manojm.site"

Copy link
Owner

@Manoj-14 Manoj-14 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I worked on it but it not worked for some cases when it is mapped to dns resolver so please update the url

Copy link
Author

@cidopenup0 cidopenup0 Jan 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ip is dynamic, so have to update it manually when the k8s namespace gets created

that is why i have been suggesting http://notification-service:8083 thingy

---
apiVersion: v1
kind: Service
Expand Down
2 changes: 1 addition & 1 deletion manifests/kubernetes/notification-mysql.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ metadata:
name: notification-mysql-config
namespace: microforge-dev-ns
data:
MYSQL_DATABASE: empdirempnotification
MYSQL_DATABASE: empnotification
---
apiVersion: v1
kind: Service
Expand Down