-
Notifications
You must be signed in to change notification settings - Fork 5
feat(slack): add reminder on postmortem incident #89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
jennafauconnier
wants to merge
6
commits into
main
Choose a base branch
from
feature/tag-incident-commander
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #89 +/- ##
==========================================
- Coverage 62.83% 62.55% -0.29%
==========================================
Files 215 216 +1
Lines 9587 9677 +90
Branches 1289 1305 +16
==========================================
+ Hits 6024 6053 +29
- Misses 3354 3415 +61
Partials 209 209
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
bca3de7 to
3829cb3
Compare
GabDug
suggested changes
Jul 25, 2024
7fade0b to
68acc72
Compare
Collaborator
|
/rerun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement Postmortem Reminder Notifications in Slack
Description
This pull request introduces a feature that sends reminder messages for incidents requiring postmortem updates in Slack. It ensures that reminders are sent to the commanders and the appropriate channels based on the incident's status and the time since the last update.
Changes Made
- If a reminder to the commander was sent more than two days ago and no channel message exists, a new reminder will be sent to the incident's channel.
- If no reminder has ever been sent to the commander and the last incident update was over two days ago, a direct reminder will be sent to the commander.
Motivation and Context
How to Test
A reminder is sent to the incident's channel if the last reminder to the commander was sent more than two days ago.
A direct reminder is sent to the commander if no reminder has ever been sent and the last incident update was over two days ago.
Checklist