Skip to content

Conversation

@NicolasLafitteMM
Copy link
Collaborator

No description provided.

@NicolasLafitteMM NicolasLafitteMM changed the title Changes due to flow not working Change incident closure with PM status check Dec 16, 2025
juanjogarciatorres43 and others added 2 commits December 16, 2025 11:02
- Replace blind Exception catch with specific jira_exceptions.JIRAError and AttributeError
- Add noqa comment for lazy JiraClient import to suppress PLC0415
- Fix test mock to patch JiraClient at correct module path

These changes ensure ruff and pre-commit checks pass after rebasing from main.
@NicolasLafitteMM NicolasLafitteMM force-pushed the feat/pm_before_close_incident branch from 39c4685 to c3d4179 Compare December 16, 2025 10:16
@codecov-commenter
Copy link

codecov-commenter commented Dec 16, 2025

Codecov Report

❌ Patch coverage is 54.28571% with 16 lines in your changes missing coverage. Please review.
✅ Project coverage is 67.64%. Comparing base (303c862) to head (62b385a).
⚠️ Report is 14 commits behind head on main.

Files with missing lines Patch % Lines
src/firefighter/slack/views/modals/close.py 0.00% 10 Missing ⚠️
src/firefighter/jira_app/service_postmortem.py 40.00% 3 Missing ⚠️
src/firefighter/incidents/models/incident.py 83.33% 0 Missing and 2 partials ⚠️
src/firefighter/confluence/models.py 85.71% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #195      +/-   ##
==========================================
+ Coverage   67.46%   67.64%   +0.17%     
==========================================
  Files         213      212       -1     
  Lines        9925     9852      -73     
  Branches     1084     1076       -8     
==========================================
- Hits         6696     6664      -32     
+ Misses       2938     2918      -20     
+ Partials      291      270      -21     
Flag Coverage Δ
unittests 67.64% <54.28%> (+0.17%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@juanjogarciatorres43 juanjogarciatorres43 force-pushed the feat/pm_before_close_incident branch 2 times, most recently from f29ecba to 1ad9640 Compare December 17, 2025 11:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants