Lint and tests #155
Open
Lint and tests #155
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove redundant Critical/Normal button selection after impact selection: - Remove button generation in _build_response_type_blocks() while preserving summary display - Remove action handlers for incident_open_set_res_type_critical/normal - Add automatic response type calculation based on priority (P1-P3=critical, P4-P5=normal) - Handle "no impact selected" case by returning None values instead of priority 6 - Add type checking and conversion for impact descriptions to handle string IDs - Add test environment support to skip usergroup invitations when TEST_MODE=true This reduces the incident creation workflow from 4 steps to 3 steps by eliminating the manual selection that duplicated the automatic priority calculation. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add modern type annotations across models and views - Update Django migrations with improved type hints - Enhance test coverage for Slack modals and API endpoints - Fix linting issues and improve code style consistency - Update admin interfaces with better type safety - Improve error handling in Confluence and RAID integrations - Add proper typing to Celery settings and SSO configuration - Enhance PagerDuty models with modern Django patterns These changes improve code maintainability and leverage Django 4.2+ features while maintaining backwards compatibility and following modern Python practices.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.