Colors & Regex support for MathTex MObjects#4420
Closed
BinaryQuantumSoul wants to merge 5 commits intoManimCommunity:mainfrom
Closed
Colors & Regex support for MathTex MObjects#4420BinaryQuantumSoul wants to merge 5 commits intoManimCommunity:mainfrom
BinaryQuantumSoul wants to merge 5 commits intoManimCommunity:mainfrom
Conversation
for more information, see https://pre-commit.ci
Member
|
Thanks for the efforts -- but closing this in favor of the full refactor of |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2884
Overview: What does this pull request change?
ColoredSingleStringMathTexclass uses latexxcolorpackage to set default colors of a TeX expression.It can take both a
tex_to_tex_color_map(String->Color) and aregex_to_tex_color_map(Regex->Color) map.ColoredSingleStringMathTexand has two new optional arguments with the same name for this same usage.regexes_to_isolateandregex_to_color_mapwhich acts exactly likesubstrings_to_isolateandtex_to_color_mapbut allow for regex keys.Motivation and Explanation: Why and how do your changes improve the library?
Right now for all complex TeX
expressions, we have to rely on workarounds like\over` or use character indices to target specific string colors. With this method, only a map is required and can work for all animations, no matter their complexity. For example, this code would never have worked earlier :Here a regex maps all numbers to yellow.
Links to added or changed documentation pages
TODO ?
Reviewer Checklist