App features #894

ThomasKroes · 2025-05-02T09:16:37Z

No description provided.

…ary include

…n base class

…ure action

…gle notifications

- Added summary item - Added HTML description

…feature

- Improve app feature HTML files - Add const action getters in the abstract settings manager - The user must give explicit consent after reading app feature description

…features are enabled

…videos model)

…earning center pages when the corresponding app features are enabled

Copilot

Pull request overview

This pull request introduces a comprehensive app features system to manage optional downloadable content in ManiVault Studio. The changes provide users with granular control over which dynamic features they want to enable, including tutorials, videos, projects, and error logging.

Key Changes:

Introduces a new AppFeatureAction base class and specific feature actions (Videos, Tutorials, Projects, ErrorLogging) to manage optional app features
Refactors error logging settings into the new app features framework
Renames toggle action variables throughout the codebase to include "Section" suffix for improved clarity and consistency

Reviewed changes

Copilot reviewed 50 out of 50 changed files in this pull request and generated 36 comments.

Show a summary per file

File	Description
ManiVault/src/actions/AppFeatureAction.h/cpp	New base class for managing app features with consent dialogs and enable/disable functionality
ManiVault/src/actions/*AppFeatureAction.h/cpp	Individual app feature implementations for Videos, Tutorials, Projects, and ErrorLogging
ManiVault/src/AppFeaturesSettingsAction.h/cpp	New settings action that groups all app features together
ManiVault/src/private/SettingsManager.h/cpp	Adds app features settings and removes deprecated error logging settings
ManiVault/src/AbstractSettingsManager.h	Updates interface with const overloads and app features support
ManiVault/src/private/StartPageContentWidget.h/cpp	Renames toggle actions with "Section" suffix and integrates tutorials app feature visibility
ManiVault/src/private/StartPageGetStartedWidget.cpp	Adds conditional tutorials widget visibility based on app feature setting
ManiVault/src/private/LearningPageContentWidget.h/cpp	Renames actions and integrates videos/tutorials app feature visibility controls
ManiVault/src/private/HelpMenu.cpp	Conditionally adds videos and tutorials menus based on app feature settings
ManiVault/src/private/HelpManager.cpp	Updates to support videos DSN synchronization and app feature-based visibility
ManiVault/src/models/LearningCenterVideosModel.h/cpp	Adds DSN synchronization capability and app feature integration
ManiVault/src/models/LearningCenterTutorialsModel.cpp	Integrates tutorials app feature check in DSN synchronization
ManiVault/src/actions/StringAction.h/cpp	Adds new TextBrowser widget type for HTML content display
ManiVault/src/actions/GroupAction.h/cpp	Removes unnecessary virtual keywords and improves code formatting
ManiVault/src/private/ErrorManager.cpp	Refactors error logging integration (work in progress with TODOs)
ManiVault/src/private/AppFeaturesDialog.h/cpp	Renamed from ErrorLoggingConsentDialog to support all app features
ManiVault/res/html/AppFeature*.html	New HTML resources describing each app feature for consent dialogs
ManiVault/src/PluginFactory.h/cpp	Adds videos DSN action for plugin-provided video content
ManiVault/src/CoreInterface.h	Adds constSettings() convenience function for const access
ManiVault/cmake/*.cmake	Updates CMake configuration to include new app feature files

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2025-12-24T09:13:47Z

ManiVault/src/private/HelpMenu.cpp

+		addMenu(mv::help().getVideosMenu());
+
+    if (tutorialsAppFeatureEnabledAction.isChecked())
+		addMenu(mv::help().getTutorialsMenu());


Inconsistent whitespace detected. This line uses a tab character for indentation while the surrounding code uses spaces. Please use consistent spacing throughout the file.

Copilot · 2025-12-24T09:13:48Z

ManiVault/src/actions/ProjectsAppFeatureAction.h

+//TODO
+//public: // Action getters
+//
+//    const ToggleAction& getTutorialsAction() const { return _tutorialsAction; }
+//    const ToggleAction& getProjectsAction() const { return _projectsAction; }
+//
+//private:
+//    ToggleAction    _tutorialsAction;   /** Toggle tutorials dynamic content */
+//    ToggleAction    _projectsAction;    /** Toggle projects dynamic content */


Incomplete TODO comments. These comments in the file indicate work in progress but provide no context about what needs to be done. Please either complete the implementation or add details about what's needed.

Copilot · 2025-12-24T09:13:48Z

ManiVault/src/private/SettingsManager.h

-    gui::AppearanceSettingsAction& getAppearanceSettingsAction() override { return _appearanceSettingsAction; };
-    gui::TemporaryDirectoriesSettingsAction& getTemporaryDirectoriesSettingsAction() override { return _temporaryDirectoriesSettingsAction; };
-    gui::ErrorLoggingSettingsAction& getErrorLoggingSettingsAction() override { return _errorLoggingSettingsAction; };
+    //gui::AppFeaturesSettingsAction& getAppFeaturesSettingsAction() override { return _appFeaturesSettingsAction; }


Commented-out code. The line contains a commented-out method declaration. If this is no longer needed, it should be removed. If it's still needed, please add a comment explaining why it's temporarily disabled.

Copilot · 2025-12-24T09:13:48Z

ManiVault/src/private/StartPageContentWidget.cpp

+    connect(&tutorialsAppFeatureEnabledAction, &ToggleAction::toggled, this, [this](bool toggled) -> void {
+        if (toggled)
+            _toggleTutorialsSectionAction.setChecked(true);
+	});


Inconsistent whitespace detected. This line uses a tab character for indentation while the surrounding code uses spaces. Please use consistent spacing throughout the file.

Copilot · 2025-12-24T09:13:49Z

ManiVault/src/private/HelpManager.cpp

Inconsistent whitespace detected. This line uses a tab character for indentation while the surrounding code uses spaces. Please use consistent spacing throughout the file.

Copilot · 2025-12-24T09:13:56Z

ManiVault/src/private/StartPageContentWidget.cpp

+    connect(&tutorialsAppFeatureEnabledAction, &ToggleAction::toggled, this, [this](bool toggled) -> void {
+        if (toggled)
+            _toggleTutorialsSectionAction.setChecked(true);
+	});


Potential dangling reference issue. The lambda captures tutorialsAppFeatureEnabledAction by reference and is connected to a signal. If this lambda outlives the scope where tutorialsAppFeatureEnabledAction is defined, the reference will be invalid. Consider capturing by value or ensuring the lambda's lifetime is properly managed.

Copilot · 2025-12-24T09:13:56Z

ManiVault/src/private/HelpManager.cpp

+    const auto toggleVisibility = [tutorialsMenu, &tutorialsAppFeatureEnabledAction]() -> void {
+        tutorialsMenu->setEnabled(tutorialsAppFeatureEnabledAction.isChecked());


Potential dangling reference issue. The lambda captures tutorialsAppFeatureEnabledAction by reference and is connected to a signal. If this lambda outlives the scope where tutorialsAppFeatureEnabledAction is defined, the reference will be invalid. Consider capturing by value or ensuring the lambda's lifetime is properly managed.

Copilot · 2025-12-24T09:13:57Z

ManiVault/src/private/ErrorManager.cpp

+        // TODO
+        //errorLoggingSettingsAction.addAction(&getLoggingAskConsentDialogAction());
+        //errorLoggingSettingsAction.addAction(&getLoggingEnabledAction());
+        //errorLoggingSettingsAction.addAction(&getLoggingDsnAction());
+        //errorLoggingSettingsAction.addAction(&getLoggingShowCrashReportDialogAction());


Incomplete TODO comments. These comments indicate work in progress but provide no context about what needs to be done. Please either complete the implementation or add details about what's needed.

Copilot · 2025-12-24T09:13:57Z

ManiVault/src/actions/TutorialsAppFeatureAction.h

+// TODO
+//public: // Action getters
+//
+//    const ToggleAction& getTutorialsAction() const { return _tutorialsAction; }
+//    const ToggleAction& getProjectsAction() const { return _projectsAction; }
+//
+//private:
+//    ToggleAction    _tutorialsAction;   /** Toggle tutorials dynamic content */
+//    ToggleAction    _projectsAction;    /** Toggle projects dynamic content */


Incomplete TODO comments. These comments in the file indicate work in progress but provide no context about what needs to be done. Please either complete the implementation or add details about what's needed.

Copilot · 2025-12-24T09:13:57Z

ManiVault/src/actions/AppFeatureAction.cpp

+        }
+
+        updateActionsReadOnly();
+        //mv::help().addNotification("App Feature", QString("%1 app feature has been %2").arg(text(), toggled ? "enabled" : "disabled"), StyledIcon(toggled ? "toggle-on" : "toggle-off"));


Commented-out notification code. This line contains a commented-out call to add a notification. If this feature is not yet ready for production, please add a comment explaining when/why it should be enabled. Otherwise, if it's no longer needed, it should be removed.

Suggested change

//mv::help().addNotification("App Feature", QString("%1 app feature has been %2").arg(text(), toggled ? "enabled" : "disabled"), StyledIcon(toggled ? "toggle-on" : "toggle-off"));

ThomasKroes added 10 commits April 28, 2025 14:33

Rename consent form

d23ee1c

Rename error logging consent dialog

3ac2523

Rename app features consent dialog and modify cmake

8c748af

Rename app features consent dialog

f73ec0d

Add app features dialog to dedicated source gorup and remove unnecess…

0c5a167

…ary include

Rename error logging consent dialog

0f2715f

Load correct app features HTML file

36ef746

Change app features HTML resource and removed unused include

337a46f

Rename error logging settings action

d2e6b48

Modify cmake accordingly

0dd651f

ThomasKroes added the enhancement New feature or request label May 2, 2025

ThomasKroes self-assigned this May 2, 2025

ThomasKroes added 18 commits May 2, 2025 11:26

Further refactor of error logging classes and added app feature actio…

95f339f

…n base class

Remove redundant friend declaration and comment unused member functions

0838d27

Add dynamic content app feature action

285be81

Work on app feature implementation

69dafa1

Work on app feature action class

fc024c5

Fix app featurre action overload and work on dynamic content app feat…

0db33c5

…ure action

Refactor

77b5a9e

Add other dynamic content app feature actions and add app feature tog…

c6a41ec

…gle notifications

Merge branch 'master' into feature/app_features

2837814

Merge branch 'master' into feature/app_features

d8e3b66

Group several app features into downloadable content app features

3afaef2

Merge branch 'master' into feature/app_features

4890c32

Work on downloadable content app feature

03025bb

Merge branch 'master' into feature/app_features

f322867

Fix downloadable content

fa70ba7

Work on app feature action and some re-structuring

b519a48

App featur action is working properly now

3d4e8da

- Added summary item - Added HTML description

Conditionally hide the settings action

bd32b93

ThomasKroes added 14 commits May 6, 2025 12:58

Move error logging DSN and other parameters to the error logging app …

7031f86

…feature

Cleanup error logging app feature class

cdf91d1

Streamline settings IO

f38347c

Several improvements:

18015b2

- Improve app feature HTML files - Add const action getters in the abstract settings manager - The user must give explicit consent after reading app feature description

Use tutorials app feature setting in the start page

9c4a139

Only show videos and tutorials help menus when the corresponding app …

bdec6a0

…features are enabled

Use the tutorials app feature in the tutorials model

90145ee

Use videos and tutorials app features in the learning center

c329354

Add videos dsns action to plugin factory

6e8572c

Removed redundant file downloader from the help manager (relocate to …

ea54ae5

…videos model)

Videos learning center model now uses the videos app feature

135ae80

Automatically toggle videos and tutorials sections of the start and l…

14710c7

…earning center pages when the corresponding app features are enabled

Change projects disclaimer

987fc02

Merge branch 'master' into feature/app_features

298c2b6

ThomasKroes requested a review from Copilot December 24, 2025 09:07

Copilot started reviewing on behalf of ThomasKroes December 24, 2025 09:07 View session

Copilot AI reviewed Dec 24, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

App features #894

App features #894

Uh oh!

ThomasKroes commented May 2, 2025

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Copilot AI Dec 24, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

		const auto toggleVisibility = [tutorialsMenu, &tutorialsAppFeatureEnabledAction]() -> void {
		tutorialsMenu->setEnabled(tutorialsAppFeatureEnabledAction.isChecked());

App features #894

Are you sure you want to change the base?

App features #894

Uh oh!

Conversation

ThomasKroes commented May 2, 2025

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Copilot AI Dec 24, 2025

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants