Pearson correlation distance metric#2
Open
maltekuehl wants to merge 3 commits intoManciukic:masterfrom
Open
Conversation
…elation against. All tests now passing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey,
this PR adds support for the Pearson correlation distance metric and distance metric test. This increases the usefulness of XPySOM for the application in computational biology where correlation metrics often outperform (see: FuseSOM, https://www.biorxiv.org/content/10.1101/2023.01.18.524659v2).
This PR should have no impact on users not looking to use the Pearson correlation distance metric. The argument name
correlationis in line with other packages in the broader ecosystem, e.g., RAPIDS.ai and scipy.If there are any issues or suggestions, I'll be happy to resolve them. We can always maintain the code separately but would be happy to re-integrate it into the library to increase discoverability.
Best regards,
Malte