informer test: reduce flakyness by waiting for correct state#587
Merged
cben merged 1 commit intoManageIQ:masterfrom Dec 20, 2022
Merged
informer test: reduce flakyness by waiting for correct state#587cben merged 1 commit intoManageIQ:masterfrom
cben merged 1 commit intoManageIQ:masterfrom
Conversation
cben
reviewed
Nov 28, 2022
|
|
||
| def watch_to_update_cache | ||
| watcher = @client.watch_entities(@resource_name, watch: true, resource_version: @started) | ||
| @watcher = @client.watch_entities(@resource_name, watch: true, resource_version: @started) |
Collaborator
There was a problem hiding this comment.
Is it worth adding @watcher = nil in #initialize ? It'd be purely cosmetic, to "announce" to reader what attrs will be used. However being internal to this method, maybe actually this one is not interesting to "announce"? 🤷 Fine either way.
Collaborator
There was a problem hiding this comment.
Similar question for @worker which is shared across 2 methods, so there I'd say worth "announcing".
cben
reviewed
Nov 28, 2022
Collaborator
|
just for the record, this still had a CI failure https://github.com/ManageIQ/kubeclient/actions/runs/3560257866/jobs/5980172236#step:6:224 |
Collaborator
|
@grosser whenever I "Re-run all jobs", I'm getting 1–2 failures... |
Contributor
Author
|
maybe this helps #593 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
hopefully improving on #586 (comment)
before we waited a set amount of time and now we wait until the watcher is ready
... which will stop and fail in that spot if it never got ready