merge Common into kubeclient to simplify setup#497
Merged
cben merged 1 commit intoManageIQ:masterfrom Mar 31, 2021
Merged
Conversation
Collaborator
|
Thanks! I merged some other PRs so has conflicts now. |
Contributor
Author
|
rebased |
Collaborator
|
truffleruby failed: Sounds like issues you recently fixed #494 (comment)? |
Contributor
Author
|
yeah, I think it's a race condition in the test ... let me restart the test to see if it goes away, can fix the test in another PR |
48ffb67 to
3ddf8af
Compare
Contributor
Author
|
... it keeps happening on truffle ruby, but always a different test-case, so skipped informer test for truffle-ruby until I have time to do a more reliable fix for it |
Contributor
Author
|
all good now 👍 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #492 (comment)
@cben
... after this is merged some cleanup to make methods private would be good