fix: use layout(color) for proper color space handling

[Manabu-GT]

Summary

• Use layout(color) uniform half4 in AGSL shaders instead of plain uniform float4 for all color uniforms
• Switch from setFloatUniform(name, r, g, b, a) to setColorUniform(name, color.toArgb()) in UniformBinder
• Ensures Android automatically converts colors from sRGB to the canvas working color space (e.g. Display P3) on wide-gamut devices

Test plan

• Build and install sample app on device
• Verify Rain, Snow, Clouds, and LightningFlash effects render correctly
• Visually confirm no color regression on sRGB and wide-gamut displays

🤖 Generated with Claude Code

Summary by CodeRabbit

• Bug Fixes
  • Enhanced color rendering accuracy and performance in weather visual effects (clouds, lightning, rain, and snow).
  • Optimized shader color uniform declarations and binding mechanisms for improved efficiency in color data handling and rendering.

[coderabbitai]

📝 Walkthrough

Walkthrough

Color uniform handling is refactored across the codebase. The Kotlin-side UniformBinder now converts colors to ARGB integers via toArgb() and passes them directly to setColorUniform(). Simultaneously, shader declarations are updated from float4 to half4 with layout(color) qualifiers for color uniforms across multiple weather components.

Changes

Cohort / File(s)	Summary
Color Binding Refactor aether/src/main/kotlin/com/ms/square/aether/core/internal/UniformBinder.kt	Simplified color binding by replacing manual RGBA component extraction with toArgb() conversion, passing ARGB integers directly to setColorUniform(). Added import for toArgb().
Shader Color Uniform Updates aether/src/main/kotlin/com/ms/square/aether/weather/Clouds.kt, aether/src/main/kotlin/com/ms/square/aether/weather/LightningFlash.kt, aether/src/main/kotlin/com/ms/square/aether/weather/Rain.kt, aether/src/main/kotlin/com/ms/square/aether/weather/Snow.kt	Updated shader color uniform declarations from uniform float4 to layout(color) uniform half4 for cloudColor, flashColor, rainColor, haloColor, tintColor, and snowColor uniforms.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~10-15 minutes

🚥 Pre-merge checks | ✅ 3 | ❌ 1

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Docstring Coverage	⚠️ Warning	Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%.	Write docstrings for the functions missing them to satisfy the coverage threshold.

✅ Passed checks (3 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly summarizes the main change: updating color handling in AGSL shaders to use layout(color) for proper color space handling, which is the primary objective across all modified files.
Merge Conflict Detection	✅ Passed	✅ No merge conflicts detected when merging into main
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/colorspace

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}