Add prioritize_line_class_coverage option#43
Open
trsxxii wants to merge 3 commits intoMalinskiy:masterfrom
Open
Add prioritize_line_class_coverage option#43trsxxii wants to merge 3 commits intoMalinskiy:masterfrom
prioritize_line_class_coverage option#43trsxxii wants to merge 3 commits intoMalinskiy:masterfrom
Conversation
Owner
|
Hey @trsxxii Thanks for the PR. Upon review I think it makes sense to have both options: prioritise branch/line coverage. Would you be able rework this to support an enum of sorts to select branch vs line? Thanks much! FYI: Travis is removed from the repo, I suggest merging with latest master to have the GitHub Actions config applied properly |
|
up @trsxxii |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @Malinskiy
Added an option to prioritize LINE (C0) coverage output for each class.
This is because even though the total coverage always outputs C0 coverage, the per-class coverage was prioritizing C1 if C1 was available. This would cause inconsistency, so the option to output C0 coverage was necessary.
The default behavior has been made the same as before, so there is no need for users to do anything after the upgrade. Users only need to set this option if they need it.
Thank you.