Add workarounds for Windows x64 builds #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both CAttributeList::RemoveAttribute and CAttributeList::SetRuntimeAttributeValue are broken on Windows; the latter results in an zero-filled entry in the attribute list when using the semantically-correct SDKType_Pointer. Likely an issue with the 64-bit Windows SDKCall patches; for now we use vscript workarounds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CAttributeManager::AttribHookValue<float>on Windows x64 since it works with the original calling convention / parameter order.CAttributeList::RemoveAttributeandCAttributeList::SetRuntimeAttributeValueto use VScript calls. I'm guessing port64 has issues with pointer types used as parameters, but I haven't dug into it to confirm.Currently untested (I tested the workarounds but that was before I cleaned up the plugin to PR the changes); should have it tested and ready to go in about 12 hours. Maybe.