You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
thanks for putting this rather obscure tool out there and making it easy to use.
parsing links was mostly implemented, but not enabled.
I changed the output link syntax from [[url|alias]] to [url alias] - this is what my moinmoin wiki documents and accepts as correct link syntax. I just noticed that this is not what the official wiki documents - not sure where that syntax change originates..
Hello! Thank you for bringing this piece of history to light. 🙂 And also doing research on link syntax.
As for the link parsing, the current implementation is correct for wikis that run 1.6.0+ and as such I can't simply merge it as it would break conversion for anyone on those versions. But I'm open to supporting older syntax versions (although I don't envy you using those) by having some flag in the core that would change the parsing behaviour depending on the targeted Moin version. The web interface could have a checkbox along the lines of use legacy link syntax or even a picker for targeted Moin versions if there are more changes to syntax across versions than the links.
Are you willing to poke into this and update the PR with those changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
thanks for putting this rather obscure tool out there and making it easy to use.
parsing links was mostly implemented, but not enabled.
I changed the output link syntax from
[[url|alias]]to[url alias]- this is what my moinmoin wiki documents and accepts as correct link syntax. I just noticed that this is not what the official wiki documents - not sure where that syntax change originates..edit: oof, moin apparently changed link syntax in 1.6.0 (2007) - we're running something older..