Skip to content

Enable converting Links#3

Open
EconomicTouristsArmLate wants to merge 2 commits intoMalanius:developfrom
EconomicTouristsArmLate:feat/parselinks
Open

Enable converting Links#3
EconomicTouristsArmLate wants to merge 2 commits intoMalanius:developfrom
EconomicTouristsArmLate:feat/parselinks

Conversation

@EconomicTouristsArmLate
Copy link

@EconomicTouristsArmLate EconomicTouristsArmLate commented Aug 24, 2023

thanks for putting this rather obscure tool out there and making it easy to use.
parsing links was mostly implemented, but not enabled.

I changed the output link syntax from [[url|alias]] to [url alias] - this is what my moinmoin wiki documents and accepts as correct link syntax. I just noticed that this is not what the official wiki documents - not sure where that syntax change originates..

edit: oof, moin apparently changed link syntax in 1.6.0 (2007) - we're running something older..

@Malanius
Copy link
Owner

Hello! Thank you for bringing this piece of history to light. 🙂 And also doing research on link syntax.

As for the link parsing, the current implementation is correct for wikis that run 1.6.0+ and as such I can't simply merge it as it would break conversion for anyone on those versions. But I'm open to supporting older syntax versions (although I don't envy you using those) by having some flag in the core that would change the parsing behaviour depending on the targeted Moin version. The web interface could have a checkbox along the lines of use legacy link syntax or even a picker for targeted Moin versions if there are more changes to syntax across versions than the links.

Are you willing to poke into this and update the PR with those changes?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants