Skip to content

zip.unzip: use built-in ZipReader instead of unzip command #165

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
DeeJayLSP wants to merge 1 commit into
base: main
Choose a base branch
from
Open

zip.unzip: use built-in ZipReader instead of unzip command #165

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
56 changes: 18 additions & 38 deletions src/extensions/zip.gd
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,45 +2,25 @@ class_name zip

static func unzip(zip_path: String, target_dir: String) -> void:
DirAccess.make_dir_absolute(target_dir)
var reader := ZIPReader.new()
if reader.open(zip_path) == OK:
var destination := DirAccess.open(target_dir)
for zip_file_name in reader.get_files():
if zip_file_name.ends_with("/"):
destination.make_dir_recursive(zip_file_name)
continue

var output := []
var exit_code: int
if OS.has_feature("windows"):
exit_code = OS.execute(
"powershell.exe",
[
"-command",
"\"Expand-Archive '%s' '%s'\" -Force" % [
ProjectSettings.globalize_path(zip_path),
ProjectSettings.globalize_path(target_dir)
]
], output, true
)
Output.push(output.pop_front())
Output.push("unzip executed with exit code: %s" % exit_code)
elif OS.has_feature("macos"):
exit_code = OS.execute(
"unzip",
[
"%s" % ProjectSettings.globalize_path(zip_path),
"-d",
"%s" % ProjectSettings.globalize_path(target_dir)
], output, true
)
Output.push(output.pop_front())
Output.push("unzip executed with exit code: %s" % exit_code)
elif OS.has_feature("linux"):
exit_code = OS.execute(
"unzip",
[
"-o",
"%s" % ProjectSettings.globalize_path(zip_path),
"-d",
"%s" % ProjectSettings.globalize_path(target_dir)
], output, true
)
Output.push(output.pop_front())
Output.push("unzip executed with exit code: %s" % exit_code)
var file_contents := reader.read_file(zip_file_name)
var file_path := destination.get_current_dir().path_join(zip_file_name)
destination.make_dir_recursive(file_path.get_base_dir())
var file := FileAccess.open(file_path, FileAccess.WRITE)
if not file:
reader.close()
return
file.store_buffer(file_contents)
file.close()

reader.close()


## A procedure that unzips a zip file to a target directory, keeping the
Expand Down